Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strings in whitelist to avoid mismatch of object_id #797

Merged
merged 1 commit into from Aug 19, 2016
Merged

Use strings in whitelist to avoid mismatch of object_id #797

merged 1 commit into from Aug 19, 2016

Conversation

ghost
Copy link

@ghost ghost commented Aug 7, 2016

I had a problem while trying to rescue_from an custom error defined inside application (in app/controllers/concerns). During debug I discovered that CustomError.object_id did not match the one from exception_class_whitelist.

To avoid this I propose to compare class names as strings rather than objects.

@lgebhardt lgebhardt merged commit 3c06c3c into cerebris:master Aug 19, 2016
@lgebhardt
Copy link
Member

@nooulaif Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants