Refactor for operations support #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All base spec requests now are handled in a single operation OperationResults functions moved to the ResponseDocument OperationDispatcher functions moved to ActsAsResourceController
lgebhardt
force-pushed
the
base_ops_refactor
branch
from
1a87249
to
53a246e
Compare
|
Great work, @lgebhardt! This should be a solid foundation for processing multiple operations. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is preparing for the support of multiple operations in a request. A separate PR to add that support will be coming shortly.
All base spec requests now are handled in a single operation:
This is needed to have a one to one mapping of responses to operations.
OperationResults functions moved to the ResponseDocument:
This change is needed to allow subsequent operations to reference the results of prior operations through the use of JSON pointers. For this to function the results must be serialized after processing and the RequestParser will need access to the prior results to resolve pointers. So the need for an intermediate storage of operation results is no longer needed.
OperationDispatcher functions moved to ActsAsResourceController.