Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #20 : Added Custom Router with animation #21

Merged
merged 1 commit into from Dec 20, 2018
Merged

Fixes #20 : Added Custom Router with animation #21

merged 1 commit into from Dec 20, 2018

Conversation

yashLadha
Copy link
Contributor

@yashLadha yashLadha commented Dec 20, 2018 •
edited

  • Added Custom Router for providing animation and named routing
  • Changed for UserPref in the Splash to redirect to the events page, if exists.

ezgif com-video-to-gif

aashutoshrathi
aashutoshrathi approved these changes Dec 20, 2018
View reviewed changes
Copy link
Member

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aashutoshrathi
Copy link
Member

BTW, what's green screen?

@yashLadha
Copy link
Contributor Author

yashLadha commented Dec 20, 2018 via email

@aashutoshrathi aashutoshrathi merged commit 77e2006 into cerebro-iiitv:master Dec 20, 2018
singhpratyush added a commit that referenced this pull request Dec 23, 2018
@singhpratyush
Revert "Fixes #20 : Added Custom Router with animation (#21)"
bc892de 
This reverts commit 77e2006.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashutoshrathi aashutoshrathi aashutoshrathi approved these changes

@DipanshKhandelwal DipanshKhandelwal Awaiting requested review from DipanshKhandelwal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yashLadha @aashutoshrathi