Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-16): migrate to react 16 #7

Merged
merged 5 commits into from
Sep 20, 2022
Merged

Conversation

dubisdev
Copy link
Contributor

@dubisdev dubisdev commented Sep 17, 2022

This PR is part of our plan to migrate to last react version

Done

  • Updated react-select to v3 (from v1)
  • Renamed css modules to .module.css
  • Using cerebro-build to bundle the package

Realted PRs

Deprecations

  • Preload component: As we are now using react 16, useEffect hook simplifes how we can get async data.
import {useState, useEffect} from "react"

const MyComponent = () => {
  const [data, setData] = useState(null)

  useEffect(() => {
    // do stuff here and call setData
  }, [])

  if (!data) // return your loader
  
  return // a component which uses `data`

}

Breaking changes

@ogustavo-pereira ogustavo-pereira changed the title chore: migrate to react 16 refactor(react-16): migrate to react 16 Sep 19, 2022
@ogustavo-pereira ogustavo-pereira marked this pull request as ready for review September 20, 2022 02:39
@ogustavo-pereira ogustavo-pereira merged commit 288b913 into master Sep 20, 2022
@ogustavo-pereira ogustavo-pereira deleted the react-16 branch February 5, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants