Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make analytics opt-in #512

Closed
1 of 2 tasks
edwardgalligan opened this issue Sep 7, 2020 · 7 comments · Fixed by #577
Closed
1 of 2 tasks

Make analytics opt-in #512

edwardgalligan opened this issue Sep 7, 2020 · 7 comments · Fixed by #577

Comments

@edwardgalligan
Copy link

  • I am on the latest Cerebro.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: macOS 10.15.6

  • Cerebro.app version: 0.3.0 (latest from https://cerebroapp.com/ )

  • Relevant information from devtools N/A

Issue

I just installed Cerebro and the app immediately tried to open multiple connections to Google.com & Google Analytics. This type of functionality should at the very least be configurable; better yet opt-in. An onboarding screen with this option would be a good UX flow.

Either way, it should definitely not be making such connections on first-run. This is a pretty bad first-impression of the app for new users.

@dubisdev
Copy link
Contributor

Hi @oguhpereira
I have been reading this issue and I think we should remove analytics because:

  1. None of the current team members is able to access the analytics so they are useless
  2. Crash reports are OK but, why do we want to collect analytics?

I'll open a PR for removing them 🚮

@gerroon
Copy link

gerroon commented Dec 26, 2022

Hi,

Is this implemented ? I do not see any settings to disable tracking, and it still connects to GA regularly, at least on Windows.

@dubisdev
Copy link
Contributor

dubisdev commented Dec 26, 2022

Hi @gerroon all the code related to analytics was removed in #577 (this includes the options to disable them, as they don't exist)

Make sure you are using the latest cerebro version

Maybe some of the plugins you are using are sending data to GA? I'm 100% sure Cerebro is not.

The only reports that exist are uploaded to crashes.cerebroapp.com (these are crash reports, not including any analytics) in

submitURL: 'http://crashes.cerebroapp.com/post',

BTW, that reports are not being used as nobody of the current development team has access to that domain. (Just legacy code that hasn't been removed yet)

@gerroon
Copy link

gerroon commented Dec 26, 2022

Thanks for the update.

This is a fresh install and no plugin is installed. It does not connect to GA (no packets) but it does a domain query to it. I will investigate it further.

@gerroon
Copy link

gerroon commented Dec 27, 2022

I also this querried by cerebro? suggestqueries.google.com

Edit: It looks like there is a default search engine plugin installed. This was a fresh install on Linux.

@dubisdev
Copy link
Contributor

Hi @gerroon , yes! That is the autocomplete endpoint for the search plugin. Here you can see it:

https://github.com/cerebroapp/search/blob/363261473d3090937b141833ccbcd1e50a1b4e94/src/handlers/google.tsx#L6

In the first run Cerebro installs some plugins to make it easy to start using it.

You can see them here:

const DEFAULT_PLUGINS = [

BTW you can configure the search engine you are using or simply remove the plugin.

Hope this helps!

@gerroon
Copy link

gerroon commented Dec 27, 2022

@dubisdev Thanks for the info and heads up. This looks great finally a cross platform desktop search utility for multiple platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants