Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Select current text with cmd+a #629

Merged
merged 1 commit into from
Nov 14, 2022
Merged

feat: Select current text with cmd+a #629

merged 1 commit into from
Nov 14, 2022

Conversation

dubisdev
Copy link
Contributor

cmd+a was working on Windows as it is a native command on Windows (works out of the box).

Now this command should be available in all platforms.

NOTE: There is a lot of work to do to improve Cerebro component. Migrating to newer React versions will allow us to use the event.code instead of event.keyCode that is deprecated and is also less readable than event.code

event.code === "KeyC" // We know is char C
event.keyCode === 67 // We can't know what char it is

fix #628

Copy link
Contributor

@ChFlick ChFlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Weird that it doesn't work on mac out of the box, it's also a native command there.

@dubisdev dubisdev merged commit 061943c into master Nov 14, 2022
@ChFlick ChFlick deleted the fix-628 branch November 14, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select-all shortcut (CMD-a) is not working on Mac
2 participants