Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CTest module #79

Closed
wants to merge 1 commit into from
Closed

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Oct 13, 2021

So that calling ctest actually runs the test.

@mpatrascoiu
Copy link
Contributor

Hello Mattias,

I'm not sure what was the intention of Georgios, whether he removed CTest by mistake or he planned to stop using it altogether.

Other projects under DMC moved away from CTest.

@ellert
Copy link
Contributor Author

ellert commented Oct 14, 2021

How do you run the tests?
The CMakeList.txt files uses add_test(). This adds a test to the set of tests ctest runs, but if the CTest module is not included add_test() is a no-op.
The spec file runs ctest in the %check section. Without including the CTest module, this invocation does not run any tests but simply says "no tests found".
Do you run the tests some other way?

@mpatrascoiu
Copy link
Contributor

I'm not sure we still have a %check section in the Davix specfile.

We run the tests in the gitlab-CI pipeline by executing davix-unit-tests. [1]
This executable is provided by the davix-tests package.

[1] .gitlab-ci.yaml#L144

@ellert
Copy link
Contributor Author

ellert commented Oct 14, 2021

OK, so instead of calling ctest I can use the following %check section:

%check
%{_vpath_builddir}/test/unit/davix-unit-tests

That works without the proposed change in this PR.

@mpatrascoiu
Copy link
Contributor

I believe this is the best way to go forward.
I will mark this ticket as closed, then.

Thanks again for the Davix support!

@mpatrascoiu mpatrascoiu mentioned this pull request Oct 14, 2021
@ellert ellert deleted the include-ctest branch October 14, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants