Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Zoom Rooms #23

Merged
merged 13 commits into from
Jul 12, 2023
Merged

Add support for Zoom Rooms #23

merged 13 commits into from
Jul 12, 2023

Conversation

renefs
Copy link
Member

@renefs renefs commented Jul 12, 2023

  • get all zoom rooms
  • get zoom room details
  • get zoom room sensor data

tomasr8 and others added 13 commits June 1, 2023 14:13
@tomasr8
Simplify get_project_dir()
5349b02
@renefs
Merge pull request #21 from tomasr8/project-dir
311c9bc 
Simplify `get_project_dir()`
@SamuelGuillemet
Typo in import inside example of Readme
c2841d2
@SamuelGuillemet
Create util function to create dict from TypedDict with NotRequired
0840e9e
@SamuelGuillemet
Improve typed dict parameters to work with from and to date
6a3409f
@SamuelGuillemet
Add component for zoom room
3535ef1
@SamuelGuillemet
Add Room component to zoom client
49acf51
@SamuelGuillemet
Add example to interact with zoom room
6bb4558
@SamuelGuillemet
Add zoom rooms to documentation
7b189b8
@SamuelGuillemet
Fix typo in CONTRIBUTING.md
dea3129
@SamuelGuillemet
Fix logger requested changes
0201e53
@SamuelGuillemet
Change name of generate_parameters_dict
2867e76
@renefs
Merge pull request #22 from SamuelGuillemet/feature/zoom-room
a8399a5 
Feature/zoom room

-Add example to interact with zoom room
- Add Zoom Room Component to zoom client
- Add tests according to the component
- Add a function to generate dict from TypedDict with NotRequired and from_date and to_date fields
- Correct typo in import inside example of Readme
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #23 (a8399a5) into main (6714076) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   99.46%   99.77%   +0.30%     
==========================================
  Files          10       12       +2     
  Lines         377      441      +64     
==========================================
+ Hits          375      440      +65     
+ Misses          2        1       -1
Impacted Files Coverage Δ
..._client/client_components/rooms/rooms_component.py 100.00% <100.00%> (ø)
zoom_python_client/utils/file_system.py 100.00% <100.00%> (ø)
zoom_python_client/utils/typed_dict_parameters.py 100.00% <100.00%> (ø)
zoom_python_client/zoom_api_client.py 100.00% <100.00%> (+0.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renefs renefs merged commit 13d8847 into main Jul 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@renefs @tomasr8 @SamuelGuillemet