Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Update space styling for Item-Displays in Clinical-Item-Collection #113

Closed
1 of 4 tasks
neilpfeiffer opened this issue Jun 28, 2017 · 2 comments
Closed
1 of 4 tasks

Comments

@neilpfeiffer
Copy link
Member

neilpfeiffer commented Jun 28, 2017

Issue Description

Fix line-height/margin/padding/vertical-aligment of Displays when presented in the table view of the Clinical Item Collection, so that all text “baselines” are aligned and icons and text all appear to look centered vertically when there is only one line of text content.

Issue Type

  • New Feature
  • Enhancement
  • Bug
  • Other

Expected Behavior

All Text and icons, when there is only a single line of content, in the table view should appear visually "centered" or aligned to the same baseline.

Current Behavior

Start and End Accessories (icons) correctly display vertically centered. The Clinical Item Displays (text) are correctly aligned top but when single line of text, they align too high visually (row height could be too tall) and icons, the basic displays, and the comments - all align to different visual baselines.

Required Enhancement

Will resolve fix comment added in PR #91

@emilyrohrbough
Copy link
Contributor

@neilpfeiffer PR #104 should have fixed this issue. Can you check to see if this was resolved when you get a chance?

@neilpfeiffer
Copy link
Member Author

@emilyrohrbough Excellent. Looks good!

Closing this issue as being resolved after merging PR #104

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants