Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Item Collection Component #91

Merged
merged 54 commits into from
Jun 28, 2017
Merged

Item Collection Component #91

merged 54 commits into from
Jun 28, 2017

Conversation

emilyrohrbough
Copy link
Contributor

Summary

Item Collection component implementation. A Item Collection is a wrapper component designed to display data as either a table or list of items dependent on the relative container size.

@cerner/terra

Rohrbough,Emily added 30 commits April 25, 2017 16:49
@mjhenkes mjhenkes temporarily deployed to terra-clinical-deployed-pr-91 June 23, 2017 04:00 Inactive
@emilyrohrbough emilyrohrbough temporarily deployed to terra-clinical-deployed-pr-91 June 23, 2017 16:32 Inactive
@emilyrohrbough emilyrohrbough temporarily deployed to terra-clinical-deployed-pr-91 June 23, 2017 16:33 Inactive
@emilyrohrbough emilyrohrbough temporarily deployed to terra-clinical-deployed-pr-91 June 23, 2017 20:37 Inactive
@emilyrohrbough emilyrohrbough temporarily deployed to terra-clinical-deployed-pr-91 June 26, 2017 15:38 Inactive
@emilyrohrbough emilyrohrbough temporarily deployed to terra-clinical-deployed-pr-91 June 26, 2017 16:32 Inactive
@emilyrohrbough emilyrohrbough temporarily deployed to terra-clinical-deployed-pr-91 June 27, 2017 18:28 Inactive
@emilyrohrbough emilyrohrbough temporarily deployed to terra-clinical-deployed-pr-91 June 27, 2017 21:16 Inactive
@mjhenkes mjhenkes temporarily deployed to terra-clinical-deployed-pr-91 June 28, 2017 14:19 Inactive
@neilpfeiffer
Copy link
Member

neilpfeiffer commented Jun 28, 2017

 Tested: PR #91

Reviewed:

  • Follows initial implementation of the clinical item collection (formerly the CompactCard) and responsive behavior of switching between table and list layouts at a specified breakpoint.
Pass Comments
UX Review -pass for initial release – requires enhancement-

.
Required Enhancement: resolve with new issue #113

  • Fix line-height/margin/padding/vertical-aligment of Displays when presented in the table view and when there is only one line of text so that all text “baselines” are aligned and icons and text all look centered vertically on same line.

Update: Required Enhancement resolved by PR #104

@emilyrohrbough
Copy link
Contributor Author

Address Issue #100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants