Action header - Add AriaLabel Text #50
Conversation
# Conflicts: # packages/terra-clinical-site/package.json # packages/terra-clinical-site/webpack.config.js
| @@ -104,6 +114,11 @@ var propTypes = { | |||
| onPrevious: _propTypes2.default.func, | |||
|
|
|||
| /** | |||
| * Locale for i18n of accessability text. | |||
| **/ | |||
| locale: _propTypes2.default.string, | |||
There was a problem hiding this comment.
Should setting locale be at the application level?
There was a problem hiding this comment.
| }, | ||
| "peerDependencies": { | ||
| "react": "15.4.2", | ||
| "react-dom": "15.4.2", | ||
| "react-intl": "^2.3.0", |
There was a problem hiding this comment.
We need this package?
| @@ -69,108 +75,148 @@ const defaultProps = { | |||
| onNext: null, | |||
| onPrevious: null, | |||
| children: null, | |||
| locale: 'en-US', | |||
There was a problem hiding this comment.
I'd talk to some of the i18n people, but I thought I remembered someone saying we shouldn't default locale's in one of our meeting, if that turns out to be the case, I'd probably mark the locale as required and remove the default
There was a problem hiding this comment.
Is the locale handled by the release of terra-base v0.5.0?
|
@jmsv6d are there changes you still need to make on this PR? |
| @@ -0,0 +1,243 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
The lib directory is now ignored from version control and generated via the compile script after running npm install and when publishing an npm package.
This means we can delete this file.
.gitignore
Outdated
| @@ -51,3 +51,4 @@ reports | |||
| screenshots | |||
| target | |||
| lib | |||
| **/aggregated-translations/*.* | |||
There was a problem hiding this comment.
If we're adding this to .gitignore, we should also delete the folder itself.
| @@ -71,6 +76,15 @@ const defaultProps = { | |||
| children: null, | |||
| }; | |||
|
|
|||
| const contextTypes = { | |||
There was a problem hiding this comment.
I am still curious, with adding contextTypes, do we still need to pass in the locale prop.
There was a problem hiding this comment.
Ooops, no. Removed the locale prop.
Summary
Adding aria-label text for the icons on the buttons in the action header.
Thanks for contributing to Terra.
@cerner/terra