-
Notifications
You must be signed in to change notification settings - Fork 50
[terra-clinical-item-view] Fix for null item displays #924
Conversation
Based on the referenced defect, it sounds like the issue seen by the consumer is around |
@smason0 omg really good catch, for some reason I assumed based on the description in the Jira but didn't realize the code snippet was pointing to that. I added the check in this commit c861937#diff-a09eb4a886b729c86a83daac740d9a14a92e66fe733a7a907899150b7fdae956 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 with passing build
Summary
What was changed:
displays
prop is passed in, added check (didn't use ? here for readability)displays
contains a null item display in the array and a check was added as wellWhy it was changed:
displays
prop and get an error with the latest changesTesting
This change was tested using:
Before:
![image](https://private-user-images.githubusercontent.com/37750902/273317727-274431ab-0674-483f-81a5-5537f36d3007.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE5NTQ5NjUsIm5iZiI6MTcyMTk1NDY2NSwicGF0aCI6Ii8zNzc1MDkwMi8yNzMzMTc3MjctMjc0NDMxYWItMDY3NC00ODNmLTgxYTUtNTUzN2YzNmQzMDA3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI2VDAwNDQyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlMTgyNTE4NmEyZjQzM2Q2NTZmYzlmZTU2OTZkZTI3MTdiMzliZjMwMDc1YmZlNWM1MWNjNjQzNmJjM2EwOTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Yin07KqFll3WfCa8d8gFpZyNBtMYeo87KSRw6eJEQuE)
After:
![image](https://private-user-images.githubusercontent.com/37750902/273318704-15b03e16-9942-4907-94f9-c3ca2a24a86c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE5NTQ5NjUsIm5iZiI6MTcyMTk1NDY2NSwicGF0aCI6Ii8zNzc1MDkwMi8yNzMzMTg3MDQtMTViMDNlMTYtOTk0Mi00OTA3LTk0ZjktYzNjYTJhMjRhODZjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI2VDAwNDQyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVjYmFiZGY2ZTNkNTIwNGUyZTIyOWJmYTc5OTFlNzJmMzdlMWI1MjIzNzZjODQ2NGRmNWIwMTRlM2QyY2EyNDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QWv-ZWcKnpEVCTwzIVFuWoEHWO1ru7pEGNJ9276dSfA)
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9711
Thank you for contributing to Terra.
@cerner/terra