Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Update packages eslintignore to point to configuration in root #30

Closed
Matt-Butler opened this issue Feb 27, 2017 · 2 comments
Closed

Update packages eslintignore to point to configuration in root #30

Matt-Butler opened this issue Feb 27, 2017 · 2 comments

Comments

@Matt-Butler
Copy link
Contributor

When running npm run lint in an individual package, the .eslitignore file is not honored.

Update

    "lint:js": "../../node_modules/.bin/eslint **/*.js, **/*.jsx",

to

    "lint:js": "../../node_modules/.bin/eslint **/*.js, **/*.jsx --ignore-path ../../.eslintignore",
@Matt-Butler
Copy link
Contributor Author

@bjankord
Copy link
Contributor

bjankord commented Feb 27, 2017

@Matt-Butler and I tested this some more.

We landed on updating
"lint:js": "../../node_modules/.bin/eslint **/*.js, **/*.jsx",
to
"lint:js": "$(cd ..; npm bin)/eslint --ext .js,.jsx . --ignore-path ../../.eslintignore"

For the component package.json files

For the root package.json, we can update it to the following:
"lint": "eslint --ext .js,.jsx .",

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants