This repository has been archived by the owner on May 24, 2024. It is now read-only.
Consume changes from terra-toolkit and terra-dev-sever #156
Merged
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4adcc7c
Consume changes from terra-toolkit and terra-dev-sever
mjhenkes 2e17aa3
run the right wdio command
mjhenkes 0e08082
up the memory available, to webpack for prod
mjhenkes 4bd77e5
update location to pull config from
mjhenkes 9061f02
Merge branch 'master' into consume-new-terra-toolkit-terra-dev-server
mjhenkes 77421cc
Hoist terra-framework. Hoist apparently doesn't work on out of sync v…
mjhenkes 7b2994e
consume released terra-toolkit
mjhenkes 7300a4b
Merge branch 'master' into consume-new-terra-toolkit-terra-dev-server
mjhenkes b7d6b72
Master merge
mjhenkes 2adbd9e
Update package.json
mjhenkes 74c980f
Merge branch 'master' into consume-new-terra-toolkit-terra-dev-server
mjhenkes 23b417d
update packages to point to root wdio
mjhenkes e8f47d1
hoist
mjhenkes File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
web: npm run start:express | ||
web: npm run start-heroku |
246 changes: 123 additions & 123 deletions
246
generatedComponentConfig.js → dev-site-config/generatedComponentConfig.js
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone have a good idea for aliasing out this file to something more friendly without having to include a webpack config locally?
node_modules/terra-dev-site/src/webpack/webpack.config.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe provide a terra-dev-site script that will wrap webpack such that it takes args ?.
Thinking
compile:prod: 'NODE_ENV=production node --max_old_space_size=3000 tds-prode'
which maps to
tds-prod.js which calls
shelljs(webpack.js --config ../../src/webpack/webpack.config.js -p)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually should we be using the servestatic script here by chance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've thought about wrapping, but I want to avoid wrapping webpack because i don't want ot duplicate all the different webpack config options that exist (there are a ton).
Serve static could be used, but creating the artifacts is a by-product of running the server and there are cases where we just want the build output (deploying to gh-pages).