New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume changes from terra-toolkit and terra-dev-sever #156
Changes from 12 commits
4adcc7c
2e17aa3
0e08082
4bd77e5
9061f02
77421cc
7b2994e
7300a4b
b7d6b72
2adbd9e
74c980f
23b417d
e8f47d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
web: npm run start:express | ||
web: npm run start-heroku |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ | |
"terra-base": "^3.0.0" | ||
}, | ||
"devDependencies": { | ||
"terra-props-table": "^2.0.0" | ||
"terra-props-table": "^2.4.0" | ||
}, | ||
"dependencies": { | ||
"classnames": "^2.2.5", | ||
|
@@ -46,6 +46,6 @@ | |
"lint:scss": "stylelint src/**/*.scss", | ||
"test": "npm run test:jest && npm run test:wdio", | ||
"test:jest": "jest ./tests/jest/* --config ../../jestconfig.json", | ||
"test:wdio": "wdio ../../wdio.conf.js" | ||
"test:wdio": "../../node_modules/.bin/wdio ../../node_modules/terra-dev-site/config/wdio/wdio.conf.js" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should make this change in the generator There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed, but the downside is that it's different between core and framework because core uses it's own wdio config and framework uses the default. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😞 yeah... |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd hold of on using the --hoist flag until we can verify it works with the theme repos. Right now, I know it works with terra-ui, but I wasn't able to get it working the cerner-consumer-theme repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, but we should pause this PR until we can verify
--hoist
works. It significantly lowers the memory footprint of the dev site.