This repository has been archived by the owner on May 24, 2024. It is now read-only.
Renaming variables, for ocs-theme-variables branch #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…framework into rename-ocs-theme-variables
* ocs-theme-variables: [terra-application-layout] and [terra-application-header-layout] updates for themeing [terra-application-links] screenshot fixes and removed extra variables [terra-time-input] fix hover and focus states for themeing, new screenshots [terra-application-layout] fix z-index for theming [terra-application-layout] and [terra-application-header-layout] adding themeable variables and update screenshot tests Revert "enable travis builds." enable travis builds. Add Packages Requiring I18n to Readme (#404) [terra-application-name] fix test & screenshots [terra-application-name] themeable to hide accessory [terra-application-name] themeable to hide accessory [terra-application-name] update layout for theming Match Dependency Versions (#400) [terra-application-links] fix font inherit and theme test [terra-application-links] update variable names [terra-application-links] update variable name [terra-application-links] update structure for theming, update screenshots Prevent click events from propagating from popup overlay (#383) Add optional toolbar prop to terra-navigation-side-menu (#352) Migrate Time Input to Framework Repo (#382) # Conflicts: # packages/terra-application-layout/src/header/ApplicationHeader.module.scss # packages/terra-application-layout/tests/wdio/application-header-spec.js # packages/terra-application-links/src/tabs/ApplicationTabs.module.scss # packages/terra-application-name/src/ApplicationHeaderName.module.scss # packages/terra-application-name/src/ApplicationMenuName.module.scss
* ocs-theme-variables: Update LayoutSlidePanel.module.scss [terra-application-header-layout] correction updates for theming [terra-application-links] correction updates for theming [terra-application-links] correction updates for theming [terra-layout] add theming variables [terra-application-utility] add theming variable # Conflicts: # packages/terra-application-links/src/tabs/ApplicationTabs.module.scss # packages/terra-application-utility/src/utility/_UtilityButton.module.scss # packages/terra-layout/src/LayoutSlidePanel.module.scss
…e variable names that had conflicts and were overwritten when rebasing with the ocs-theme-variables branch.
…ariables in the tests
BenBoersma
requested review from
bjankord,
JakeLaCombe,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com>
Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com>
Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com>
Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com>
Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com>
yuderekyu
reviewed
Jan 11, 2019
bjankord
approved these changes
Jan 15, 2019
yuderekyu
approved these changes
Jan 16, 2019
tbiethman
approved these changes
Jan 16, 2019
mjhenkes
approved these changes
Jan 16, 2019
ryanthemanuel
pushed a commit
that referenced
this pull request
Jan 25, 2019
* [terra-slide-panel] add background image theme var. * [terra-slidepanel] typo * [terra-slide-panel] add border-radius theme var. * [terra-slide-panel] move border radius to panel. * [terra-slide-panel] add border-radius theme var for full screen. add theme var test. * [terra-slide-panel] extract background-color and image to main and panel classes. * [terra-dialog-modal] add box shadow theme var * [terra-application-name] add font size * [terra-application-name] change background color of default menu name test. update screenshots * [terra-application-name] remove background color from menu test component. * [terra-application-utility] - add more button styles * [terra-application-utility] - add more theme vars for menu utility button. update tests and typos. * [terra-application-utility] - update menu theme vars * [terra-application-utility] change divider border top theme vars and update tests * [terra-application-utility] correct header icon theme vars * [terra-application-utility] - add min height to header * [terra-application-utility] add focus and hover states to icons. * [terra-application-utility] add background color to focus states * [terra-application-utility] update theme tests to test combinations of theme values. speeds tests up :) * [terra-navigation-side-menu] - add background color to focus state * [terra-navigation-side-menu] add focus active color to chevron svg. * [terra-navigation-side-menu] make height and width css vars instead of props. * [terra-application-layout] add more theme vars * [terra-application-layout] - add margin-right to user data info. * [terra-application-links] add borders to acive state. update theme test. * [terra-application-links] refactor selected state theme vars. update tests. * [terra-application-links] correct invalid background-position * [terra-application-links] add background color to focused collapsed item. * [terra-application-links] correct theme var test * [terra-slide-panel] remove background-images. refactor overlay and squish theme variables. * [terra-slide-panel] add background image theme var. * [terra-slidepanel] typo * [terra-slide-panel] add border-radius theme var. * [terra-slide-panel] move border radius to panel. * [terra-slide-panel] add border-radius theme var for full screen. add theme var test. * [terra-slide-panel] extract background-color and image to main and panel classes. * [terra-dialog-modal] add box shadow theme var * [terra-application-name] add font size * [terra-application-name] change background color of default menu name test. update screenshots * [terra-application-name] remove background color from menu test component. * [terra-application-utility] - add more button styles * [terra-application-utility] - add more theme vars for menu utility button. update tests and typos. * [terra-application-utility] - update menu theme vars * [terra-application-utility] change divider border top theme vars and update tests * [terra-application-utility] correct header icon theme vars * [terra-application-utility] - add min height to header * [terra-application-utility] add focus and hover states to icons. * [terra-application-utility] add background color to focus states * [terra-application-utility] update theme tests to test combinations of theme values. speeds tests up :) * [terra-navigation-side-menu] - add background color to focus state * [terra-navigation-side-menu] add focus active color to chevron svg. * [terra-navigation-side-menu] make height and width css vars instead of props. * [terra-application-layout] add more theme vars * [terra-application-layout] - add margin-right to user data info. * [terra-application-links] add borders to acive state. update theme test. * [terra-application-links] refactor selected state theme vars. update tests. * [terra-application-links] correct invalid background-position * [terra-application-links] add background color to focused collapsed item. * [terra-application-links] correct theme var test * [terra-slide-panel] remove background-images. refactor overlay and squish theme variables. * Adding themeable variables for icon width and height for notification dialog * Updating terra-application-header-layout variable to use full package name instead of partial * [terra-modal-manager] make test example's content container explicitly white. * [terra-popup] add more theme vars to close icon and header. * Revert "[terra-modal-manager] make test example's content container explicitly white." This reverts commit a4414b4. * [terra-application-links] test adding border left to unselected tab. * [application-tabs] convert to themeCombinationOfCustomProperties. * update focus theme vars * [terra-application-utility] add color theme var for icon on utility button * [terra-application-utility] update theme vars based on ux feedback. update screenshots. * [terra-application-utility] actually add scss updates. * Updating for skip-to-content theming * [terra-slide-panel] updating theme vars and screenshots * [terra-application-utility] add margins to icons * [terra-application-links] update border and box-shadow vars * [navigation-side-menu] add background-color to menu item * Revert "[terra-application-utility] add margins to icons" This reverts commit 3841703. * Revert "Revert Tar Archive files (#343) to reference unreleased popup changes." This reverts commit 8af4cad. * Add popup tar file for testing. * [terra-application-utility] add margin bottom theme var to menu footer. add margin top theme var to menu footer items. * [terra-application-utility] fix theme var typo. update theme test to correctly apply this. * Revert the revert that brought tar files back. lolz. delete popup tar file. * [terra-application-utility] remove height from icons. regenerate screenshots for utility and application-layout. * Adding regenerated screenshots that got missed * [terra-application-utility] add right+left padding to menu-utility-button. regenerate theme screenshot. * [terra-slide-panel] fix ltr/rtl box shadows * [terra-slide-panel] fix lint errors * Revert "[terra-slide-panel] fix lint errors" This reverts commit 329ae5c. * [terra-slide-panel] fix lint errors * [terra-layout] add separate squish/overlay background * [terra-navigation-side-menu] add background-color on content-container * Updating skip-to-content button css variables and screenshots * [terra-navigation-side-menu] separated hover/focus/active/selected styling, regen screenshots * [terra-navigation-side-menu] fix variable typos and refactored for stylelint * [terra-navigation-side-menu] handling for when isRootMenu additional css to properly theme the content-container body for when the menu is the root level or no action-header provided * [terra-application-links] update structure for theming, update screenshots * [terra-application-links] update variable name * [terra-application-links] update variable names * [terra-application-links] fix font inherit and theme test * [terra-application-name] update layout for theming * [terra-application-name] themeable to hide accessory * [terra-application-name] themeable to hide accessory * [terra-application-name] fix test & screenshots * enable travis builds. * Revert "enable travis builds." This reverts commit edde2a7. * [terra-application-layout] and [terra-application-header-layout] adding themeable variables and update screenshot tests * [terra-application-layout] fix z-index for theming * [terra-time-input] fix hover and focus states for themeing, new screenshots * [terra-application-links] screenshot fixes and removed extra variables * [terra-application-layout] and [terra-application-header-layout] updates for themeing * [terra-application-utility] add theming variable * [terra-layout] add theming variables * [terra-application-links] correction updates for theming * [terra-application-links] correction updates for theming * [terra-application-header-layout] correction updates for theming * Update LayoutSlidePanel.module.scss * Temporarily turning off Changelog requirement * undoing dangerfile change * [application-utility] add style to hide close button on header menu. add word wrap to header. * [application-utility] remove spaces * [application-utility] add '--' blah * [all packages] bump terra-core deps. * [application-links] fix bad merge :[ * [application-layout] bump core deps. not yet proficient in spacemacs :[ * Updating screenshots for terra-core update * Adding other screenshots for terra-core update * Renaming variables, for ocs-theme-variables branch (#429) * Fixing terra-application-layout and adding new screenshots * Enable error linting * missed screenshot * Updating variable renames * [terra-time-input] Refactor themeable variables. * [terra-time-input] Fix duplicate property declaration lint error. * [terra-popup] Rename themeable variables to comply with lint rules. * [terra-application-link terra-layout terra-application-utility] Update variable names that had conflicts and were overwritten when rebasing with the ocs-theme-variables branch. * Updating some tests and screenshots since we forgot to update theme variables in the tests * More theme test fixes. * Splitting border right into 3 seperate propereties to keep variables easy. * Found a few variable naming errors * reverting dangerfile change * Updating style-lint as according to pr * Tests we are no longer running got their screenshots remade for some reason * Update packages/terra-application-utility/src/utility/_UtilityButton.module.scss Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com> * Update packages/terra-time-input/src/TimeInput.module.scss Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com> * Update packages/terra-time-input/src/TimeInput.module.scss Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com> * Update packages/terra-time-input/src/TimeInput.module.scss Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com> * Update packages/terra-time-input/src/TimeInput.module.scss Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com> * Update packages/terra-time-input/src/TimeInput.module.scss Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com> * Update packages/terra-time-input/src/TimeInput.module.scss Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com> * Update packages/terra-time-input/src/TimeInput.module.scss Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com> * Update packages/terra-time-input/src/TimeInput.module.scss Co-Authored-By: BenBoersma <39568848+BenBoersma@users.noreply.github.com> * Further removing keyboard from variables names to match PR request changes * Found another keyboard name * Updating tests variable names for PR, addressing PR comments * Addressing some PR Comments * Addressing PR comments, adding type to help label variable names * Added type to a variable name that didn't need it * Adding upgrade guides and changelogs * Forgot to add changelogs for the rest of the packages about the terra-core bump * Fixing jest snapshots. Fixing wdio tests for tabs, that were overwritten * Updating according to pr comments * Changing class name to better diferenaite. * Updating to match naming conventions * Updating variable names for clarity * Dependency updates * Current changes to splitting tabs * Remove whitespace * Undoing the division of the 3 classes, but needed to keep some changes in that particular commit * Upgrade guide changes as required by changes in the pr * Updating UpgradeGuides again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renaming variables in terra-framework to match the new standards
Please add your name to the CONTRIBUTORS.md file. Adding your name to the CONTRIBUTORS.md file signifies agreement to all rights and reservations provided by the License.
Thanks for contributing to Terra.
@cerner/terra