This repository has been archived by the owner on May 22, 2024. It is now read-only.
update and refactor deps to allow passive updates from consumer projects #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "style-loader": "^0.16.1", | ||
| "webpack": "^2.6.1", | ||
| "webpack-dev-server": "^2.4.5" | ||
| "shelljs": "^0.7.6" |
There was a problem hiding this comment.
shelljs is just used in the release script. I think we can move this to be a devDep
|
Update changelog |
added 2 commits
October 5, 2017 11:38
emilyrohrbough
approved these changes
Oct 5, 2017
bjankord
approved these changes
Oct 5, 2017
4 tasks
|
Just pulled this into terra-clinical and appears to run fine with webpack v2 specified there. I did receive this output:
|
mjhenkes
approved these changes
Oct 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move testing dependencies into devDependencies and made webpack and nightwatch peer dependencies. This makes it easier for consuming projects to update independent of toolkit.