terra-toolkit v5 #291

mjhenkes · 2019-05-20T14:44:36Z

Summary

These are the reverted changes re-applied. Watch this PR for the additional changes we will be making to toolkit.

@cerner/terra

terra-bot · 2019-05-20T14:55:33Z

	Warnings
⚠️	❗ Big PR. Consider breaking this into smaller PRs if applicable

Generated by 🚫 dangerJS

mjhenkes · 2019-05-24T21:46:19Z

src/wdio/services/TerraCommands/accessibility.js

-const beAccessible = (...args) => {
-  accessibleItBlock(determineOptions.axeOptions(args));
+const validatesAccessibility = (...args) => {
+  runAccessibilityTest(determineOptions.axeOptions(args));


Instead of having both functions call runAccessibilityTest, you could have itIsAccessible call validatesAccessibility

const validatesAccessibility = (...args) => { const axeResults = global.browser.axe(determineOptions.axeOptions(args)); global.expect(axeResults).to.be.accessible(); }; const itIsAccessible = (...args) => { global.it('is accessible', () => { runAccessibilityTest(...args); }); };

Talked offline, we need to keep as is for people using Terra.validates.element such the validates.element ignores viewports configuration

mjhenkes · 2019-05-24T21:46:37Z

src/wdio/services/TerraCommands/chai-methods.js

@@ -17,13 +17,13 @@ function accessible() {
  this.assert(
    errors.length === 0,
    `expected no accessibility violations but got:\n\t${errors[0]}`,
-    'expected accessibilty errors but received none',
+    'expected accessibility errors but received none',


code spell checker is amazing

mjhenkes · 2019-05-24T21:48:42Z

src/wdio/services/TerraCommands/validate-element.js

 };

-export default validateElement;
+const validatesElement = (...args) => {


you could DRY up these methods like you did for the accessibility functions above

mjhenkes · 2019-05-24T22:02:46Z

src/wdio/services/TerraCommands/visual-regression.js

+  });
+};
+
+const validatesScreenshot = (...args) => {
  const {
    name, selector, misMatchTolerance, viewports,


ignore viewports here

nfaltermeier · 2019-05-29T19:55:32Z

docs/guides/TerraToolkitUpgradeGuide-v5.0.0-part1.md

+The default form factor is now 'huge' to correct inconsistent viewport sizing that had occurred when a test used the default viewport for a test run vs defining a huge viewport. This may require screenshot updates, but no code changes are necessary.
+
+### TerraService
+- The `viewportChangePause` option was removed the `Terra.should.matchScreenshot`.


"option was removed the" -> "option was removed from the"

nfaltermeier · 2019-05-29T19:56:32Z

docs/guides/TerraToolkitUpgradeGuide-v5.0.0-part1.md

+
+For static sites, the original files will be served, you will be responsible for adding the locale to the static files.
+
+For compiled sites, the ```defaultLocale```` environment variable will be passed to the webpack config indicating what locale the site should be compiled for. This will be done automatically for projects using terra-dev-site.


```defaultLocale```` -> ```defaultLocale```

nfaltermeier · 2019-05-29T19:59:39Z

docs/guides/TerraToolkitUpgradeGuide-v5.0.0-part1.md

+```
+
+### AxeService
+The AxeService has been removed. The accessibility capabilities the Axe Service provided has been move to the Terra Service because the services could not run independently. The `axe` key can still be used for configuration and the test helper and axe chai assertion can be used. Please note, the `runOnly` option has been removed from Terra.should.beAccessible test helper and axe chai method and resetScroll has been enabled.


"has been move" -> "has been moved"

nfaltermeier · 2019-05-29T20:04:14Z

docs/guides/TerraToolkitUpgradeGuide-v5.0.0-part1.md

+The nightwatch utility and peer dependencies have been removed in this toolkit release. Be sure to remove the `nightwatch` dev-dependency in your project, if it exists.
+
+## NEXT: Upgrade to Toolkit v5
+See Part 2 for more information on the step-by-step dependency and script changes for terra-toolkit v5.


Could link to the URL part 2 will have when this is merged to master

nfaltermeier · 2019-05-29T20:05:56Z

docs/guides/TerraToolkitUpgradeGuide-v5.1.0-part2.md

@@ -0,0 +1,230 @@
+# Terra Toolkit Upgrade Guide v5.0.0 - Part 2


File has "v5.1.0" in it's name

nfaltermeier · 2019-05-29T20:15:10Z

docs/guides/TerraToolkitUpgradeGuide-v5.1.0-part2.md

+```
+
+## NEXT: Webdriver Test Updates
+See Part 3 for more information on Webdriver changes.


Also could link to the URL part 3 will have when this is merged to master

nfaltermeier · 2019-05-29T20:16:52Z

docs/guides/TerraToolkitUpgradeGuide-v5.1.0-part2.md

+```
+
+### 2. Add a `start-prod` script
+Add the following script to run `webpack-dev-server` with hot-reloading disabled to view the assets that are used during the test run.


Could be more specific about what "the assets that are used during the test run" means

package.json

terra-toolkit v5

1c1da9d

mjhenkes requested review from bjankord, ryanthemanuel and tbiethman as code owners May 20, 2019 14:44

bjankord approved these changes May 20, 2019

View reviewed changes

emilyrohrbough approved these changes May 20, 2019

View reviewed changes

Rohrbough,Emily added 12 commits May 20, 2019 11:56

changes

360f849

docs

7d0745b

docs

899128a

tweaks

798c648

matts find for fixing babel in pkge wdio runs

2160df4

tweaks

b3ba395

fix jest test

9c9b501

fix theming helper to always clean up, even on failure

070aec9

fix readme badge

e7705dd

always test page accessibility

81d6cd8

add it and validates and do some clean up

c514a2a

Okay. I think this should be everything

c14acc2

mjhenkes commented May 24, 2019

View reviewed changes

mjhenkes and others added 7 commits May 26, 2019 18:55

adding custom describe

1f8b109

Default to huge but don't do it with the formFactor variable.

576e22d

fix jest test

3c95789

update custom describe

5474c55

inline docs everywhere!!!

dc80d02

remove dev-site config loading

978e91e

working on docs

1e9b0fc

Rohrbough,Emily added 2 commits May 29, 2019 12:32

Default to .build and add error messaging

02a7ea3

Upgrade Guide Parts 1 & 2. Part 3 is coming.

21faf28

nfaltermeier reviewed May 29, 2019

View reviewed changes

mjhenkes commented May 30, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

mjhenkes added 5 commits May 30, 2019 07:34

testing new polyfil

f03fd92

move webpack pollyfill entry points to be peer dependencies

ec5ac13

update upgrade guide

ba3e91e

fix jest test

5a0c2fb

fix wdio tests

69b36e7

ryanthemanuel approved these changes May 30, 2019

View reviewed changes

mjhenkes and others added 9 commits May 30, 2019 11:09

prefer locale env over config env

fc5705e

Merge branch 'master' into v5

c9a6511

fix missed merge conflict

102785a

fix this

6a8540f

.

9ae65c4

changelog & remove upgrade guides for new pr for better review

e035ec8

Merge branch 'master' into v5

a518f15

not sure what I was doing to delete deps

408b221

update screenshots

b51d4d9

mjhenkes merged commit 4698e4b into master May 31, 2019

mjhenkes deleted the v5 branch May 31, 2019 14:32

emilyrohrbough assigned mjhenkes and emilyrohrbough May 31, 2019

emilyrohrbough added the Major Version Bump label May 31, 2019

emilyrohrbough added this to In Review in Toolkit V5 via automation May 31, 2019

emilyrohrbough moved this from In Review to Ready for Release in Toolkit V5 May 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

terra-toolkit v5 #291

terra-toolkit v5 #291

mjhenkes commented May 20, 2019

terra-bot commented May 20, 2019

mjhenkes May 24, 2019 •

edited

emilyrohrbough May 31, 2019

mjhenkes May 24, 2019

mjhenkes May 24, 2019

mjhenkes May 24, 2019

nfaltermeier May 29, 2019 •

edited

nfaltermeier May 29, 2019 •

edited

nfaltermeier May 29, 2019 •

edited

nfaltermeier May 29, 2019

nfaltermeier May 29, 2019

nfaltermeier May 29, 2019

nfaltermeier May 29, 2019 •

edited


		For static sites, the original files will be served, you will be responsible for adding the locale to the static files.

		For compiled sites, the ```defaultLocale```` environment variable will be passed to the webpack config indicating what locale the site should be compiled for. This will be done automatically for projects using terra-dev-site.

		@@ -0,0 +1,230 @@
		# Terra Toolkit Upgrade Guide v5.0.0 - Part 2

terra-toolkit v5 #291

terra-toolkit v5 #291

Conversation

mjhenkes commented May 20, 2019

Summary

terra-bot commented May 20, 2019

mjhenkes May 24, 2019 • edited

Choose a reason for hiding this comment

emilyrohrbough May 31, 2019

Choose a reason for hiding this comment

mjhenkes May 24, 2019

Choose a reason for hiding this comment

mjhenkes May 24, 2019

Choose a reason for hiding this comment

mjhenkes May 24, 2019

Choose a reason for hiding this comment

nfaltermeier May 29, 2019 • edited

Choose a reason for hiding this comment

nfaltermeier May 29, 2019 • edited

Choose a reason for hiding this comment

nfaltermeier May 29, 2019 • edited

Choose a reason for hiding this comment

nfaltermeier May 29, 2019

Choose a reason for hiding this comment

nfaltermeier May 29, 2019

Choose a reason for hiding this comment

nfaltermeier May 29, 2019

Choose a reason for hiding this comment

nfaltermeier May 29, 2019 • edited

Choose a reason for hiding this comment

mjhenkes May 24, 2019 •

edited

nfaltermeier May 29, 2019 •

edited

nfaltermeier May 29, 2019 •

edited

nfaltermeier May 29, 2019 •

edited

nfaltermeier May 29, 2019 •

edited