cli: Improve http/https dichotomy #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
reviewed
Nov 17, 2020
| @@ -112,25 +112,6 @@ the **get-file-locations** command: | |||
|
|
|||
| This command will output URIs for all the files associated with the record ID 5500, using the HTTP protocol. | |||
|
|
|||
| **HTTPS protocol** | |||
There was a problem hiding this comment.
It is good to remove this section, but then we may not be having any HTTPS note anywhere. So you can add here:
Note that you can specify `--server https://opendata.cern.ch` if you would like to use the HTTPS protocol instead.
in those places where we spoke about HTTPS... In this way when people search the docs for HTTPS they would find at least a note on this.
tiborsimko
reviewed
Nov 17, 2020
tests/test_cli_download_files.py
Outdated
| @@ -94,7 +94,7 @@ def test_download_files_https_pycurl(): | |||
| os.remove(test_file) | |||
| test_download_files = CliRunner() | |||
| test_result = test_download_files.invoke( | |||
| download_files, ["--recid", 3005, "--protocol", "https"] | |||
| download_files, ["--recid", 3005, "--server", "https://opendata-dev.cern.ch"] | |||
There was a problem hiding this comment.
This would be the only use of opendata-dev.cern.ch, so I think it is better to replace this with SERVER_HTTPS_URI from config so that we are using the same server consistently everywhere.
tiborsimko
reviewed
Nov 17, 2020
tests/test_cli_download_files.py
Outdated
| @@ -112,7 +112,7 @@ def test_download_files_https_requests(mocker): | |||
| os.remove(test_file) | |||
| test_download_files = CliRunner() | |||
| test_result = test_download_files.invoke( | |||
| download_files, ["--recid", 3005, "--protocol", "https"] | |||
| download_files, ["--recid", 3005, "--server", "https://opendata-dev.cern.ch"] | |||
Removed https protocol from protocol options, keeping only http or xrootd Accepting https with --server option closes #92
tiborsimko
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #92