Skip to content
This repository has been archived by the owner on Aug 27, 2018. It is now read-only.

templates: terms-of-use #3

Closed
tiborsimko opened this issue Jul 6, 2017 · 1 comment
Closed

templates: terms-of-use #3

tiborsimko opened this issue Jul 6, 2017 · 1 comment
Assignees

Comments

@tiborsimko
Copy link
Member

Goal

Migrate /terms-of-use page from Invenio2 to Invenio3 based CERN Open Data instance.

Old look

http://opendata.cern.ch/terms-of-use

New look

(no particular wireframe available; just port the text)

Old implementation

$ git grep -A 3 'route.*terms-of-use'
invenio_opendata/base/views.py:@blueprint.route('terms-of-use')
invenio_opendata/base/views.py-def terms():
invenio_opendata/base/views.py-    try:
invenio_opendata/base/views.py-        return render_template('termsofuse.html')
$ find . -name termsofuse.html
./invenio_opendata/base/templates/termsofuse.html

New implementation

Use Jinja template. Port the old code and clean the CSS a bit.

Additional actions

Plug the "Terms of Use" page into the new page footer.

@tiborsimko tiborsimko added this to the Sprint-Templates milestone Jul 6, 2017
hjhsalo added a commit to hjhsalo/cernopendata that referenced this issue Aug 18, 2017
* Add terms of use page.
  ( closes cernopendata/cernopendata-pages#3 )

Signed-off-by: Harri Hirvonsalo <harri.hirvonsalo@cern.ch>
@ioannistsanaktsidis
Copy link
Contributor

Closing as implemented.

tiborsimko pushed a commit to tiborsimko/opendata.cern.ch that referenced this issue Aug 29, 2017
* Add terms of use page.
  ( closes cernopendata/cernopendata-pages#3 )

Signed-off-by: Harri Hirvonsalo <harri.hirvonsalo@cern.ch>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants