Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata fields from #34 are not propagated to the datasets and tools view #120

Closed
katilp opened this issue Sep 10, 2014 · 15 comments
Closed

Metadata fields from #34 are not propagated to the datasets and tools view #120

katilp opened this issue Sep 10, 2014 · 15 comments
Milestone
v0.5

Comments

@katilp
Copy link
Member

katilp commented Sep 10, 2014

The metadata fields, which Patricia has inserted to the records from #34, do not yet propagate correctly to the view of the individual records (e.g. http://opendata.cern.ch/record/201 or any other).
Is the something you need from me for this?
@pherterich
Copy link
Member

I think @tiborsimko and @pamfilos are still adjusting the page formatting. The new metadata is there which you can see from the correct titles, the old format/design just only used 4 fields and how they have to teach the page which field to fill from where. I hope that explanation makes sense. Nothing we currently can do. I will finish the missing metadata files until lunch so they can be uploaded.

@katilp
Copy link
Member Author

katilp commented Sep 10, 2014

OK, thanks - http://opendata.cern.ch/record/611 still has the old title. Should that be updated? It is in #34 as well

@pherterich
Copy link
Member

I'm not sure which parts @tiborsimko already uploaded. Also could be my fault, as I said yesterday, some things might got lost in all my files. I'll give the IT guys some time to adjust the format and then I check a bit later and update metadata accordingly.

@katilp
Copy link
Member Author

katilp commented Sep 10, 2014

OK, thanks - just checking: the event display source code is referred to in the test tasks- Will it be in the tools collections or should I change the test task? Equally, the software to produce event display file is needed in one task.

@pherterich
Copy link
Member

Oh, they are the 2 missing parts I still have to create. Give me half an hour and they'll be ready for Tibor. I think I have to update some links in the other datasets then, but that I'll see.

@tiborsimko
Copy link
Member

http://opendata.cern.ch/record/611

This seems to come from cms-tools-code-example.xml:

@pherterich Do we still need this example file?

I think I have to update some links in the other datasets then, but that I'll see.

You can check latest contents of the files at:

BTW we are missing some record IDs. If we reload sets multiple times, records without records IDs would be uploaded twice. Here is current status:

$ git grep -c '<record>' invenio_opendata/testsuite/data/cms/            
invenio_opendata/testsuite/data/cms/cms-derived-pattuples-ana.xml:2
invenio_opendata/testsuite/data/cms/cms-eventdisplay-files.xml:11
invenio_opendata/testsuite/data/cms/cms-primary-datasets.xml:14
invenio_opendata/testsuite/data/cms/cms-tools-ana.xml:2
invenio_opendata/testsuite/data/cms/cms-tools-code-example.xml:1
invenio_opendata/testsuite/data/cms/cms-tools-vm-image.xml:1

$ git grep -c '"001"' invenio_opendata/testsuite/data/cms/             
invenio_opendata/testsuite/data/cms/cms-derived-pattuples-ana.xml:2
invenio_opendata/testsuite/data/cms/cms-eventdisplay-files.xml:11
invenio_opendata/testsuite/data/cms/cms-primary-datasets.xml:14
invenio_opendata/testsuite/data/cms/cms-tools-ana.xml:2

@pherterich As you've been inventing new record IDs for most of the sets, can you please also create some for the missing ones? (cms-tools-code-example.xml is missing record IDs, as well as cms-tools-vm-image.xml.)

@pherterich
Copy link
Member

@tiborsimko https://github.com/cernopendata/opendata.cern.ch/blob/pu/invenio_opendata/testsuite/data/cms/cms-tools-code-example.xml can be deleted. I go through and check rec-ids and cross linking now and invent the missing ones.

tiborsimko added a commit to tiborsimko/opendata.cern.ch that referenced this issue Sep 10, 2014
@tiborsimko
CMS: removal of cms-tools-code-example.xml
f9722a7 
* Removes unnecessary `cms-tools-code-example.xml` example file.
  (references cernopendata#120)

Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
@tiborsimko tiborsimko mentioned this issue Sep 10, 2014
Merged
tiborsimko pushed a commit that referenced this issue Sep 10, 2014
@pherterich @tiborsimko
CMS: update of cms-tools-vm-image.xml
90c14d8 
* Updates `cms-tools-vm-image.xml`.  (addresses #120) (PR #121)

Reviewed-by: Tibor Simko <tibor.simko@cern.ch>
@katilp
Copy link
Member Author

katilp commented Sep 10, 2014

Noticed that it would be needed to have the metadata fields for the test task in the twoleton/fourlepton analysis example. At least the link to the ana's gitbuh area. Can this be added soon?

@tiborsimko
Copy link
Member

Noticed that it would be needed to have the metadata fields for the test task in the twoleton/fourlepton analysis example. At least the link to the ana's gitbuh area. Can this be added soon?

@katilp Do you mean record 101 here?

Note there is a link in 774. Which more information needs to be added? Is @pherterich working on this?

@pherterich
Copy link
Member

the link is in 774, I can add in addition 8564 $u if that makes it easier as long as the format is not perfect

@pherterich pherterich mentioned this issue Sep 10, 2014
Closed
tiborsimko pushed a commit that referenced this issue Sep 10, 2014
@pherterich @tiborsimko
CMS: updates to cms-tools-ana.xml
ce33a12 
* Fixes software consistency.  (addresses #120)
  (addresses #112) (addresses #131) (PR #136)

Reviewed-by: Tibor Simko <tibor.simko@cern.ch>
@katilp
Copy link
Member Author

katilp commented Sep 10, 2014

@pherterich Yes, the reocrd 101 in the link above

@katilp katilp mentioned this issue Sep 10, 2014
Closed
4 tasks
@katilp
Copy link
Member Author

katilp commented Sep 10, 2014

@tiborsimko @pamfilos Do you need some information from me to connect the fields (spread by me allover in #34) to their display location in the record view pages (i.e. http://opendata.cern.ch/record/nnn) ?

@tiborsimko
Copy link
Member

Do you need some information from me to connect the fields (spread by me allover in #34) to their display location in the record view pages (i.e. http://opendata.cern.ch/record/nnn) ?

Thanks, this is not really necessary, we can parse #34. Now that we have the record JSON data model (#93), we are starting to "plug" the information to various templates. The first examples should come within an hour or two; I'll keep you posted.

tiborsimko added a commit to tiborsimko/opendata.cern.ch that referenced this issue Sep 11, 2014
@tiborsimko
templates: propagation of "issues and limitations"
a7c7d24 
* Propagates "issues and limitations" metadata information (taken from
  JSON field `documentation_note` aka MARC tag `556`) into various
  detailed record page templates.  (addresses cernopendata#120)

Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
@tiborsimko tiborsimko mentioned this issue Sep 11, 2014
Merged
@tiborsimko
Copy link
Member

@katilp @pamfilos OK, as a first example I fixed propagation of "issues and limitations" and deployed it on the live site.

How it was done:

What is does:

What can be improved:

  • presentation of links

Please have a look and let me know any comments before we propagate other metadata records.
We could split the work with @pamfilos to advance faster...

@tiborsimko tiborsimko added this to the v0.5 milestone Sep 12, 2014
@tiborsimko tiborsimko mentioned this issue Sep 12, 2014
Closed
tiborsimko added a commit to tiborsimko/opendata.cern.ch that referenced this issue Sep 13, 2014
@tiborsimko
templates: propagation of "selection" information
e630dc6 
* Propagates "selection" metadata information (taken from JSON field
  `methodology_note` aka MARC tag `567`) into various detailed record
  page templates.  (addresses cernopendata#120)

Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
@tiborsimko tiborsimko mentioned this issue Sep 13, 2014
Merged
tiborsimko added a commit to tiborsimko/opendata.cern.ch that referenced this issue Sep 13, 2014
@tiborsimko
templates: propagation of "validation" information
abd5e0b 
* Propagates "validation" metadata information (taken from JSON field
  `action_note` aka MARC tag `583`) into various detailed record page
  templates.  (addresses cernopendata#120)

Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
@tiborsimko tiborsimko mentioned this issue Sep 13, 2014
Merged
tiborsimko added a commit to tiborsimko/opendata.cern.ch that referenced this issue Sep 13, 2014
@tiborsimko
templates: propagation of "usage" information
cac2ff5 
* Propagates "usage" metadata information (taken from JSON field
  `constituent_unit_entry` aka MARC tag `774`) into various detailed
  record page templates.  (addresses cernopendata#120)

Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
@tiborsimko
Copy link
Member

All UI boxes on detailed record pages are now filled with metadata information:

  • issues and limitations
  • selection
  • validation
  • usage

Here are examples of how things look like:

I'm therefore closing this issue. Further enhancements (e.g. to display new information elements) would need new UI boxes and would be better tracked via new dedicated issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
3 participants
@tiborsimko @katilp @pherterich