-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
records: adds new CMS ML software records #2586
Conversation
Initial draft - many FIXME's to work through. |
@tiborsimko does it make sense to take care of #2585 in this PR as well (i.e. add that JSON to this file)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
"number_files": 1, | ||
"size": 11111111 | ||
}, | ||
"doi": "FIXME", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can only mint DOI once the example will be having some GitHub tag. Note that they may move to a different GitHub organisation... so I'll merge without DOI parts for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended
"attribution": "GNU General Public License (GPL) version 3" | ||
}, | ||
"publisher": "CERN Open Data Portal", | ||
"recid": "FIXME", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12101 for example, we can start incrementing there for all datascience material, datasets and samples (until ~13000)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended
} | ||
], | ||
"collections": [ | ||
"CMS-Validation-Utilities" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this is not validation code, although I see we used it in the past... http://opendata-dev.cern.ch/record/5104
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... should be rather put under CMS-Tools
collection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for CMS-Tools
(or leave out)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended
As discussed with @tiborsimko , the file can be renamed to cms-tools-Run2-datascience.json and it can host #2585 (I will make a separate PR for that) |
* (closes cernopendata#2584) Signed-off-by: Artemis Lavasa <artemis.lavasa@cern.ch> Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
Signed-off-by: Artemis Lavasa artemis.lavasa@cern.ch