Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

records: adds new CMS ML software records #2586

Merged
merged 1 commit into from
May 13, 2019

Conversation

ArtemisLav
Copy link
Member

@ArtemisLav
Copy link
Member Author

Initial draft - many FIXME's to work through.

@ArtemisLav
Copy link
Member Author

ArtemisLav commented Apr 8, 2019

@tiborsimko does it make sense to take care of #2585 in this PR as well (i.e. add that JSON to this file)?

Copy link
Member

@katilp katilp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

"number_files": 1,
"size": 11111111
},
"doi": "FIXME",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can only mint DOI once the example will be having some GitHub tag. Note that they may move to a different GitHub organisation... so I'll merge without DOI parts for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended

"attribution": "GNU General Public License (GPL) version 3"
},
"publisher": "CERN Open Data Portal",
"recid": "FIXME",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12101 for example, we can start incrementing there for all datascience material, datasets and samples (until ~13000)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended

}
],
"collections": [
"CMS-Validation-Utilities"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is not validation code, although I see we used it in the past... http://opendata-dev.cern.ch/record/5104

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... should be rather put under CMS-Tools collection

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for CMS-Tools (or leave out)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended

@katilp
Copy link
Member

katilp commented May 6, 2019

As discussed with @tiborsimko , the file can be renamed to cms-tools-Run2-datascience.json and it can host #2585 (I will make a separate PR for that)

* (closes cernopendata#2584)

Signed-off-by: Artemis Lavasa <artemis.lavasa@cern.ch>
Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
@tiborsimko tiborsimko merged commit c419b2c into cernopendata:master May 13, 2019
@ghost ghost removed the Status: in review label May 13, 2019
@tiborsimko tiborsimko added this to Done in CMS-Q4-Updates Jun 6, 2019
@ArtemisLav ArtemisLav deleted the SW-ML1 branch August 2, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

CMS: SW records for ML sample production (Run2 QCD for jettuples)
3 participants