-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic description of Jade Computing Notes #3518
Conversation
c89c6cd
to
54f727f
Compare
LGTM! |
"accelerator": "DESY-PETRA", | ||
"collaboration": { | ||
"name": "JADE collaboration", | ||
"recid": "451" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Record 451 points to the CMS collaboration author list, see https://opendata.cern.ch/record/451
I guess you meant to point to 26050 which is the record ID for JADE author list for preserved data: https://opendata-qa.cern.ch/record/26050
Note though that this is not a complete list of computing notes, perhaps we should have an "all-hands'" list of all JADE people?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then this would need correction in the loogbook file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed.
"number_files": 1, | ||
"size": 137529 | ||
}, | ||
"experiment": "JADE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The experiment field is now a list, so this should be:
"experiment": [
"JADE"
],
"abstract": { | ||
"description": "Monte Carlo Formats" | ||
}, | ||
"authors": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty "authors" field does not have to be there. You can remove it, the field is not mandatory.
"JADE-Computing-Notes" | ||
], | ||
"date_created": [ | ||
"Nov 09 1978" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
date_created
is represented collision-taking year, please see the field description in cernopendata/jsonschemas/records/record-v1.0.0.json
. It must be set to "1978" only, so that facets etc would work. Please remove the month and date.
(If we need month and date, then we should use 1978-11-09" (i.e. YYYYMMDD) as we do in "date_published" fields for the documents, but then may need to amend facet handling to created proper year. Please let me know if you wish to store also months and dates.)
"attribution": "CC0" | ||
}, | ||
"publisher": "CERN Open Data Portal", | ||
"recid": "261301", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very high record ID. You can use the following range: 26150-27999. (We'll use this range also for data and MC records later.) So you can start numbering from 26150 onwards.
"abstract": { | ||
"description": "Vertex chanber software" | ||
}, | ||
"authors": "Hagermann, Kleinworth, Ramcke", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "authors" field is a list. If you have three authors, then you should do:
"authors": [
{
"affiliation": "Orsay, LAL; Paris, IN2P3; Orsay",
"name": "Adam-Bourdarios, Claire",
"orcid": "0000-0002-2634-4958",
"rorid": "046w3ze59; 03fd77x13; 028rypz17"
},
{
"affiliation": "Royal Holloway, U. of London",
"name": "Cowan, Glen",
"orcid": "0000-0001-8363-9827",
"rorid": "04g2vpn86"
},
{
"affiliation": "INRIA, Saclay; LRI, Paris 11; Orsay",
"name": "Germain, Cecile",
"orcid": "0000-0002-9764-9783",
"rorid": "02kvxyf05; 04e3ktk27; 028rypz17"
},
]
You can obviously leave out the ORCID, RORID, affiliation fields if you don't have them for past authors.
Please note also that we prefer to have full names in the format "Familyname, Firstname".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the full names are not given and they would not be easily accessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW in hte note itself I'm seeing initials, perhaps we could at least do "Eckerlin, G" and "Zimmer, M" instead of using just family names?
(We could do this also in later improvements, after merge, if you prefer.)
"collections": [ | ||
"JADE-Computing-Notes" | ||
], | ||
"date_created": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"date_created" is mandatory and cannot be empty. If you don't know the year, perhaps we should use some placeholder such as 1970 or anything you wish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just put an approximate date there, when the work on the document was finished.
{ | ||
"checksum": "adler32:46c1eb5f", | ||
"size": 137529, | ||
"uri": "root://eospublic.cern.ch///eos/opendata/jade/documentation/notes/0Index.pdf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the extra slash in the URI. The values should be "root://eospublic.cern.ch//eos/opendata/..." here and elsewhere, otherwise the file link would not work.
15cea08
to
2f831f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, rebased and squashed. I'll create a follow-up issue on making the author names more complete.
No description provided.