Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should initialize controller-runtime logging #252

Closed
erikgb opened this issue Jun 20, 2023 · 0 comments · Fixed by #263
Closed

Should initialize controller-runtime logging #252

erikgb opened this issue Jun 20, 2023 · 0 comments · Fixed by #263

Comments

@erikgb
Copy link
Contributor

erikgb commented Jun 20, 2023

When approver-policy starts, this is logged on startup. Probably related to controller-runtime 0.15.0 upgrade.

I0620 06:50:37.637698       1 controller.go:219] controller-manager "msg"="Starting workers" "controller"="certificaterequest" "controllerGroup"="cert-manager.io" "controllerKind"="CertificateRequest" "worker count"=1
[controller-runtime] log.SetLogger(...) was never called, logs will not be displayed:
goroutine 291 [running]:
runtime/debug.Stack()
	/usr/local/go/src/runtime/debug/stack.go:24 +0x65
sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/log/log.go:59 +0xbd
sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).WithName(0xc0003e3a40, {0x1e9c6f9, 0x9})
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/log/deleg.go:147 +0x4c
github.com/go-logr/logr.Logger.WithName(...)
	/go/pkg/mod/github.com/go-logr/logr@v1.2.4/logr.go:336
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).getLogger.func1()
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/webhook/admission/webhook.go:182 +0x63
sync.(*Once).doSlow(0x0?, 0xc000101040?)
	/usr/local/go/src/sync/once.go:74 +0xc2
sync.(*Once).Do(...)
	/usr/local/go/src/sync/once.go:65
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).getLogger(0xc00026d720?, 0xc0003b4400?)
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/webhook/admission/webhook.go:180 +0x53
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).ServeHTTP(0xc00026d720, {0x7fea55a33ef8?, 0xc0004735e0}, 0xc000517200)
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.15.0/pkg/webhook/admission/http.go:96 +0xc34
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerInFlight.func1({0x7fea55a33ef8, 0xc0004735e0}, 0x2173d00?)
	/go/pkg/mod/github.com/prometheus/client_golang@v1.15.1/prometheus/promhttp/instrument_server.go:60 +0xd4
net/http.HandlerFunc.ServeHTTP(0x2173da0?, {0x7fea55a33ef8?, 0xc0004735e0?}, 0xc0013fb828?)
	/usr/local/go/src/net/http/server.go:2122 +0x2f
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerCounter.func1({0x2173da0?, 0xc000170a80?}, 0xc000517200)
	/go/pkg/mod/github.com/prometheus/client_golang@v1.15.1/prometheus/promhttp/instrument_server.go:147 +0xc5
net/http.HandlerFunc.ServeHTTP(0x7d9365?, {0x2173da0?, 0xc000170a80?}, 0x40dd0a?)
	/usr/local/go/src/net/http/server.go:2122 +0x2f
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerDuration.func2({0x2173da0, 0xc000170a80}, 0xc000517200)
	/go/pkg/mod/github.com/prometheus/client_golang@v1.15.1/prometheus/promhttp/instrument_server.go:109 +0xc7
net/http.HandlerFunc.ServeHTTP(0xc000170a80?, {0x2173da0?, 0xc000170a80?}, 0x1ea32e6?)
	/usr/local/go/src/net/http/server.go:2122 +0x2f
net/http.(*ServeMux).ServeHTTP(0xc000538ee8?, {0x2173da0, 0xc000170a80}, 0xc000517200)
	/usr/local/go/src/net/http/server.go:2500 +0x149
net/http.serverHandler.ServeHTTP({0x2164928?}, {0x2173da0, 0xc000170a80}, 0xc000517200)
	/usr/local/go/src/net/http/server.go:2936 +0x316
net/http.(*conn).serve(0xc001129dd0, {0x2174b70, 0xc000568a50})
	/usr/local/go/src/net/http/server.go:1995 +0x612
created by net/http.(*Server).Serve
	/usr/local/go/src/net/http/server.go:3089 +0x5ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant