Helm chart JSON schema validation prevents it being used as a sub-chart

[wallrj]

JSON schema validation was added to the Helm chart in #340

After releasing https://github.com/cert-manager/approver-policy/releases/tag/v0.13.0-alpha.1 to test this I discovered that it prevents me using the chart as a sub-chart in my approver-policy plugin.

The problem is that the schema validation in the approver-policy chart rejects the global chart values that are added by Helm.

The problem has been reported to the Helm maintainers by @howardjohn in helm/helm#10392 but they have dismissed it.

• Json Schema validation is not friendly when used with chart dependencies helm/helm#10392

A work around has been suggested by @ogarciacar in helm/helm#10392 (comment):

I am adding global to my sub chart json validation schema and keeping additionalProperties=false. WDYT?

      "additionalProperties": false,
      "properties": {
       "global": {
            "type": "object",
            "description": "Define global in subchart json schema",
            "default": {}
        },

Istio used this fix in istio/istio#36896

• allow global property in values schema istio/istio#36896

[wallrj]

Not fixed yet.

[wallrj]

Fixed in #391