Refactor Evaluate preparing for CEL #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
erikgb
force-pushed
the
refactor-evaluate
branch
from
d7cec47
to
da2b3fc
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
refactor-evaluate
branch
from
da2b3fc
to
55f2f2c
Compare
inteon
approved these changes
Sep 23, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When/if the CEL feature proposed in #256 is implemented, we need to change the policy evaluation logic. As the code is already quite complex and repetitive, I am in this PR suggesting a refactoring that will make the code easier to change, and review in follow-up PRs.
/cc @inteon @SgtCoDFish