Skip to content

Commit

Permalink
Merge pull request #6699 from inteon/fix_prometheus
Browse files Browse the repository at this point in the history
Fix backwards incompatible change: include a prometheus service by default
  • Loading branch information
jetstack-bot committed Feb 1, 2024
2 parents 3cdd44b + 0a79f2e commit 03e3188
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deploy/charts/cert-manager/templates/service.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.prometheus.enabled .Values.prometheus.servicemonitor.enabled }}
{{- if and .Values.prometheus.enabled (not .Values.prometheus.podmonitor.enabled) }}
apiVersion: v1
kind: Service
metadata:
Expand Down
4 changes: 3 additions & 1 deletion deploy/charts/cert-manager/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,9 @@ enableServiceLinks: false
prometheus:
# Enable Prometheus monitoring for the cert-manager controller to use with the
# Prometheus Operator. If this option is enabled without enabling `prometheus.servicemonitor.enabled` or
# `prometheus.podmonitor.enabled`, 'prometheus.io' annotations are added to the cert-manager Deployment resources.
# `prometheus.podmonitor.enabled`, 'prometheus.io' annotations are added to the cert-manager Deployment
# resources. Additionally, a service is created which can be used together
# with your own ServiceMonitor (managed outside of this Helm chart).
# Otherwise, a ServiceMonitor/ PodMonitor is created.
enabled: true

Expand Down

0 comments on commit 03e3188

Please sign in to comment.