Fix a bug in helm chart where webhook had controller feature gates pa…

…ssed

This will break anyone who relied on featureGates field to pass feature gates to webhook- they will need to use the new webhook.featureGates field

Signed-off-by: irbekrm <irbekrm@gmail.com>

deploy/charts/cert-manager/templates/webhook-deployment.yaml

@@ -72,7 +72,7 @@ spec:
           - --secure-port={{ .Values.webhook.securePort }}
           {{- end }}
           {{- if .Values.featureGates }}
-          - --feature-gates={{ .Values.featureGates }}
+          - --feature-gates={{ .Values.webhook.featureGates }}
           {{- end }}
           {{- $tlsConfig := default $config.tlsConfig "" }}
           {{ if or (not $config.tlsConfig) (and (not $tlsConfig.dynamic) (not $tlsConfig.filesystem) ) -}}

deploy/charts/cert-manager/values.yaml

@@ -70,7 +70,7 @@ podDisruptionBudget:
   # or a percentage value (e.g. 25%)
 
 # Comma separated list of feature gates that should be enabled on the
-# controller pod & webhook pod.
+# controller pod.
 featureGates: ""
 
 # The maximum number of challenges that can be scheduled as 'processing' at once
@@ -341,6 +341,10 @@ webhook:
   # Path to a file containing a WebhookConfiguration object used to configure the webhook
   # - --config=<path-to-config-file>
 
+  # Comma separated list of feature gates that should be enabled on the
+  # webhok pod.
+  featureGates: ""
+
   resources: {}
     # requests:
     #   cpu: 10m

make/e2e-setup.mk

@@ -270,7 +270,7 @@ e2e-setup-certmanager: $(BINDIR)/cert-manager.tgz $(foreach binaryname,controlle
 		--set installCRDs=true \
 		--set featureGates="$(feature_gates_controller)" \
 		--set "extraArgs={--kube-api-qps=9000,--kube-api-burst=9000,--concurrent-workers=200}" \
-		--set "webhook.extraArgs={--feature-gates=$(feature_gates_webhook)}" \
+		--set webhook.featureGates="$(feature_gates_webhook)" \
 		--set "cainjector.extraArgs={--feature-gates=$(feature_gates_cainjector)}" \
 		--set "dns01RecursiveNameservers=$(SERVICE_IP_PREFIX).16:53" \
 		--set "dns01RecursiveNameserversOnly=true" \