Remove `securityContext.enabled` from helm chart #4721

Dean-Coakley · 2022-01-08T08:25:40Z

Remove deprecated securityContext.enabled field from helm chart. It has already been replaced by securityContext which supports arbitrary yaml instead.

fixes #4445

Release note:

Remove deprecated field `securityContext.enabled` from helm chart

jetstack-bot · 2022-01-08T08:25:49Z

Hi @Dean-Coakley. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

`securityContext.enabled` was deprecated and has already been replaced by `securityContext` which supports arbitrary yaml. Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>

Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>

irbekrm · 2022-01-11T09:11:44Z

Thank you very much for the contribution!

Since the securityContext.enabled was deprecated 2020 as mentioned in #4445, it makes sense to remove it 👍🏼

I've run helm template against a chart built from this branch with values file with securityContext.enabled: false and securityContext.enabled: true and can confirm that both now result in a Deployment spec with the default security context.

Given that this means a change in the generated deployment config for anyone who might still be using a Helm values file with the securityContext.enabled field, maybe we could be more explicit in the release note about what the old/new behaviour is if securityContext.enabled: false, securityContext.enabled: true was set in the values file? (i.e a simplified version of the release note here #2455 (comment))

/ok-to-test

irbekrm · 2022-03-25T14:00:52Z

/lgtm
/approve

irbekrm · 2022-03-25T14:01:27Z

/retest

maelvls · 2022-03-25T14:24:06Z

Hi! Apologies for the failures on pull-cert-manager-make-e2e-v1-23 and pull-cert-manager-make-test. This is due to changes I recently made to the Prow configuration (specifically, I have added a caching mechanism).

The tests will keep failing until #4983 gets merged to master. I will keep you updated as soon as this is done. Then the tests will start working again! 🤗

maelvls · 2022-03-25T18:11:16Z

Fixed in #4988! I will re-run the tests for you.

/test pull-cert-manager-make-test
/test pull-cert-manager-make-e2e-v1-23

jakexks

/lgtm

jetstack-bot · 2022-04-05T22:31:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dean-Coakley, irbekrm, jakexks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [irbekrm,jakexks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot · 2022-04-05T23:54:50Z