Webhook feature gates only set if controller feature gates are

[mila-rodriguez-netapp]

Describe the bug:
Pretty sure this isn't intentional and probably just a typo in the chart.

cert-manager/deploy/charts/cert-manager/templates/webhook-deployment.yaml

Lines 78 to 80 in d34bd7a

	{{- if .Values.featureGates }}
	- --feature-gates={{ .Values.webhook.featureGates }}
	{{- end }}

The --feature-gates flag in the webhook template is correctly being set to the .Values.webhook.featureGates, but the entire statement is guarded by a check that the controller feature gates exist (.Values.featureGates). Are webhook feature gates subordinate to controller feature gates? If you want to apply feature gates to the webhook but not the controller, you can't because of this.

Expected behaviour:

I would expect to be able to apply discrete feature gates to both the controller and the webhook. If I want to enable A in the controller and B in the webhook I can; but if I want to apply only B in the webhook I cannot because the template requires that the controller have a feature gate applied as well.

Steps to reproduce the bug:

--set webhook.featureGates=example should apply the feature gate flag and 'example' to the webhook, but it does not because the controller does not have any feature gates applied.

Anything else we need to know?:

As mentioned, I think this is just a typo in the template (eg should be {{- if .Values.webhook.featureGates }}) or I'm just confused about how feature gates work and you can't have webhook features without having controller features. 🤷🏼

Environment details::

• Kubernetes version: N/A
• Cloud-provider/provisioner: N/A
• cert-manager version: v1.13.0
• Install method: helm

/kind bug

[irbekrm]

Hi, yes, that's a bug, we fixed a related bug in #6093 but looks like missed that line.

Would you like to submit a fix?

[RipulHandoo]

Hey @irbekrm!!
Do we have to update this
{{- if .Values.featureGates }}
with this
{{- if .Values.webhook.featureGates }}
RIght?