-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds key parser for PKCS#8 encoded private keys. #1191
Conversation
Hi @chr-fritz. Thanks for your PR. I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From my understanding of this PR, this will allow user-supplied PKCS#8 private keys for all issuer types. It won't allow users to specify they want PKCS#8 private keys to be generated, but will allow them to be parsed. This seems reasonable, and like you say, allows user-supplied 'signing CAs' that have a PKCS#8 private key to be used with the CA issuer. /ok-to-test |
Yes thats correct. I checked the log messages of the e2e tests. All of them are timeouts while connecting to the kubernetes cluster. I let run the tests local. They worked. /retest |
Signed-off-by: Christian Fritz <christian.fritz@qaware.de>
This looks good to me 😄 thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chr-fritz, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR enables the key parser for the ca issuer to use PKCS#8 encoded private keys.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): No Issue createdSpecial notes for your reviewer:
The changes in the file
generate.go
is only required for the tests.Release note: