Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds key parser for PKCS#8 encoded private keys. #1191

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Adds key parser for PKCS#8 encoded private keys. #1191

merged 1 commit into from
Jan 31, 2019

Conversation

chr-fritz
Copy link
Contributor

What this PR does / why we need it:
This PR enables the key parser for the ca issuer to use PKCS#8 encoded private keys.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): No Issue created

Special notes for your reviewer:
The changes in the file generate.go is only required for the tests.

Release note:

Allow to use PKCS#8 encoded private keys in CA issuers.

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jan 10, 2019
@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2019
@jetstack-bot
Copy link
Contributor

Hi @chr-fritz. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 10, 2019
@munnerz
Copy link
Member

munnerz commented Jan 10, 2019

From my understanding of this PR, this will allow user-supplied PKCS#8 private keys for all issuer types.

It won't allow users to specify they want PKCS#8 private keys to be generated, but will allow them to be parsed.

This seems reasonable, and like you say, allows user-supplied 'signing CAs' that have a PKCS#8 private key to be used with the CA issuer.

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2019
@chr-fritz
Copy link
Contributor Author

Yes thats correct.

I checked the log messages of the e2e tests. All of them are timeouts while connecting to the kubernetes cluster. I let run the tests local. They worked.

/retest

Signed-off-by: Christian Fritz <christian.fritz@qaware.de>
@Crystal-Chun Crystal-Chun mentioned this pull request Jan 14, 2019
@munnerz
Copy link
Member

munnerz commented Jan 31, 2019

This looks good to me 😄 thanks!

/lgtm
/approve
/milestone v0.7

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@jetstack-bot jetstack-bot added this to the v0.7 milestone Jan 31, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chr-fritz, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2019
@munnerz munnerz added this to In progress in v0.7 via automation Jan 31, 2019
@jetstack-bot jetstack-bot merged commit e848bce into cert-manager:master Jan 31, 2019
v0.7 automation moved this from In progress to Done Jan 31, 2019
@chr-fritz chr-fritz deleted the parse-pkcs8 branch February 1, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
v0.7
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants