Reuse acme clients to limit use of nonce/directory/accounts endpoints #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2019 14:00
In its current state, this will leak acme clients if issuers are being changed a lot Signed-off-by: Daniel Morsing <dmo@jetstack.io>
This is a very in-elegant solution to the problem, but it avoids having to look at other extant issuers and having background processes. Signed-off-by: Daniel Morsing <dmo@jetstack.io>
jetstack-bot
added
dco-signoff: yes
jetstack-bot
added
the
area/acme
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DanielMorsing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
size/M
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Our controllers would previously generate a new acme client on each sync invocation. This would mean throwing away the anti-replay nonce and directory structure information. Use a very simple cache of acme clients to reduce the number of API calls needed.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged):fixes #1242
Release note: