Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Kubernetes dependencies to 1.13 #1268

Merged
merged 6 commits into from
Feb 22, 2019
Merged

Bump Kubernetes dependencies to 1.13 #1268

merged 6 commits into from
Feb 22, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Jan 24, 2019

What this PR does / why we need it:

Update our Kubernetes dependencies to v1.13.

This has required a few extra changes to our codebase, and I've also bumped the azure sdk too as it shares a dependency with some kubernetes packages.

Release note:

Bump Kubernetes dependencies to v1.13

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/api Indicates a PR directly modifies the 'pkg/apis' directory labels Jan 24, 2019
@munnerz
Copy link
Member Author

munnerz commented Jan 24, 2019

/kind cleanup

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2019
@munnerz munnerz force-pushed the k8s-113 branch 2 times, most recently from 4ee5697 to c0ffe3b Compare January 24, 2019 23:34
@jetstack-bot jetstack-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 24, 2019
@mengqiy
Copy link

mengqiy commented Jan 29, 2019

@munnerz ETA of this PR?

@munnerz
Copy link
Member Author

munnerz commented Jan 29, 2019

There's a few test failures I need to take a look at. Is there any particular reason you need this PR soon? 😄

@mengqiy
Copy link

mengqiy commented Jan 30, 2019

We are working on integrating cert-manager for cert management in kubebuilder.
We plan to generate some cert-manager related objects (e.g. Certificate). But kubebuilder and friend repos are all using k8s 1.13.
To craft the cert-manager CR objects, kubebuilder repos need to import cert-manager CRD APIs. If cert-manager is not on k8s 1.13, kubebulder repos can't directly use dep to import cert-manager CRD APIs due to dependency conflicting.

2 possible workarounds for us (but I'm don't like them a lot :/)

  • using [override] to let dep pin the transitive k8s dependency for cert-manager. (Not sure if everything will work)
  • using go template to do it

@munnerz
Copy link
Member Author

munnerz commented Jan 30, 2019

👍 got it. Makes sense!

I'm going to take a look at these test failures today 😄

@munnerz
Copy link
Member Author

munnerz commented Jan 31, 2019

It seems like this PR: kubernetes/kubernetes#60709 is breaking some unit tests currently. I'm investigating ways we can workaround it 😄

@munnerz
Copy link
Member Author

munnerz commented Jan 31, 2019

I've opened kubernetes/kubernetes#73601 which should hopefully fix the issue

@munnerz munnerz mentioned this pull request Jan 31, 2019
Merged
@munnerz
Copy link
Member Author

munnerz commented Feb 1, 2019

Requires #1294 for e2e tests to pass

@munnerz
Copy link
Member Author

munnerz commented Feb 5, 2019

e2es should pass now (but deps will fail as I've manually edited vendor/ whilst waiting for kubernetes/kubernetes#73601 to merge)

/retest

@gordcorp gordcorp mentioned this pull request Feb 7, 2019
Closed
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2019
@munnerz munnerz mentioned this pull request Feb 19, 2019
Closed
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2019
@munnerz munnerz force-pushed the k8s-113 branch 2 times, most recently from 9f6542d to 94aa294 Compare February 20, 2019 18:12
@munnerz
Copy link
Member Author

munnerz commented Feb 21, 2019

/retest

@DirectXMan12 DirectXMan12 mentioned this pull request Feb 22, 2019
Merged
@munnerz
Copy link
Member Author

munnerz commented Feb 22, 2019

/retest

@munnerz
Copy link
Member Author

munnerz commented Feb 22, 2019

Logs don't make it clear, but this is failing due to requiring this: openshift/generic-admission-server#21

@munnerz
Copy link
Member Author

munnerz commented Feb 22, 2019

Ah, it's actually caused by use of glog in our own project 😄 switching to klog..

@jetstack-bot jetstack-bot added area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/ca Indicates a PR directly modifies the CA Issuer code area/monitoring Indicates a PR or issue relates to monitoring area/vault Indicates a PR directly modifies the Vault Issuer code labels Feb 22, 2019
@munnerz
Bump Kubernetes libraries to 1.13.2
749ce34 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Fixup for Kubernetes 1.13.2
a9d8f7d 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz munnerz force-pushed the k8s-113 branch 2 times, most recently from 716faf3 to fe74b5b Compare February 22, 2019 12:25
@munnerz
Switch to klog
2f30258 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Remove dependence on k8s.io/ingress
4394995 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update generated files
be915d0 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Remove nonexistent flag from webhook deployment
3737966 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added the area/deploy Indicates a PR modifies deployment configuration label Feb 22, 2019
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Feb 22, 2019 •
edited

@munnerz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cert-manager-e2e-v1-11 cf9bcc4 link /test e2e v1.11
pull-cert-manager-e2e-v1-12 cf9bcc4 link /test e2e v1.12

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@munnerz
Copy link
Member Author

munnerz commented Feb 22, 2019

/retest

@munnerz
Copy link
Member Author

munnerz commented Feb 22, 2019

Finally passing 🎉

kragniz
kragniz approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

v0.7 automation moved this from Needs review to Reviewer approved Feb 22, 2019
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 8752770 into cert-manager:master Feb 22, 2019
v0.7 automation moved this from Reviewer approved to Done Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kragniz kragniz kragniz approved these changes

Assignees

@kragniz kragniz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/api Indicates a PR directly modifies the 'pkg/apis' directory area/ca Indicates a PR directly modifies the CA Issuer code area/deploy Indicates a PR modifies deployment configuration area/monitoring Indicates a PR or issue relates to monitoring area/vault Indicates a PR directly modifies the Vault Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
No open projects
v0.7
  
Done
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@munnerz @mengqiy @jetstack-bot @kragniz