Use long-lived certificates for the webhook component #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
jetstack-bot
added
release-note
jetstack-bot
added
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
|
/lgtm |
jetstack-bot
added a commit
that referenced
this pull request
Jan 31, 2019
…release-0.6 Automated cherry pick of #1276
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In v0.6.0, the webhook component was installed using certificates that don't explicitly set a
duration. This means that the new default of90dwill be used.We haven't currently tested auto-rotation of certificates in the webhook component, and we may need to signal with a SIGHUP or similar to make it reload the cert (or just watch the file on disk).
This PR increases the lifetime of these component certificates, which should at least help mitigate the issue until v0.7 is released when we have a more complete patch ready.
Release note:
/kind bug
/milestone v0.6
/cc @DanielMorsing
/shrug