Fix bug causing certficates to be re-issued endlessly in certain cases #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
area/acme
jetstack-bot
added
approved
…efore/duration Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
munnerz
force-pushed
the
fix-renewbefore
branch
from
25e2192
to
f85bf0f
Compare
Signed-off-by: James Munnelly <james@munnelly.eu>
munnerz
force-pushed
the
fix-renewbefore
branch
from
f85bf0f
to
094ae3e
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In instances where the certificate returned from the issuer has a duration different to the one specified on the
spec.duration, theIssuerOptions.Helperhad its own implementation of theCertificateNeedsRenewfunction that did not take account of this.This PR moves the
calculateDurationUntilRenewfrom the certificate controller into the helper, and uses it universally. Previously this method was only being used to schedule renewals, meaning renewal loops could occur.Which issue this PR fixes: fixes #1214
Release note: