Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when specify keyAlgorithm without an explicit keySize #1309

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Fix bug when specify keyAlgorithm without an explicit keySize #1309

merged 1 commit into from
Feb 5, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Feb 4, 2019

What this PR does / why we need it:

The previous logic here meant that if a user explicitly specified a keyAlgorithm but not keySize, a certificate would fail to be issued.

I've also updated some unit tests that had invalid input data, and added two more test cases to cover this patch.

Release note:

Fix bug when specify certificate keyAlgorithm without an explicit keySize

/kind bug
/milestone v0.6

@munnerz
Fix bug when specify keyAlgorithm without an explicit keySize
6c66185 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 4, 2019
@jetstack-bot jetstack-bot added this to the v0.6 milestone Feb 4, 2019
@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Feb 4, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2019
@munnerz
Copy link
Member Author

munnerz commented Feb 5, 2019

/retest

@munnerz munnerz mentioned this pull request Feb 5, 2019
Merged
@DanielMorsing
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2019
jetstack-bot added a commit that referenced this pull request Feb 5, 2019
@jetstack-bot
Merge pull request #1312 from munnerz/automated-cherry-pick-of-#1309-…
ea28e7c 
…release-0.6

Automated cherry pick of #1309
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

2 similar comments
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot jetstack-bot merged commit 99a9a04 into cert-manager:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kragniz kragniz Awaiting requested review from kragniz

Assignees

@DanielMorsing DanielMorsing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@munnerz @jetstack-bot @DanielMorsing @retest-bot