Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kubernetes dependencies to 1.10.12 #1344

Merged
merged 2 commits into from
Feb 11, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Feb 8, 2019

What this PR does / why we need it:

Bumps the patch version of Kubernetes from 1.10.0 to 1.10.12 in order to resolve some issues around the webhook.

This does not replace the bump for 1.13, but instead is a temporary stop gap that we can cherry pick into the v0.6 release.

Which issue this PR fixes: fixes #1220

Release note:

Bump Kubernetes apimachinery dependencies to v1.10.12

/milestone v0.6
/kind bug
/area important-soon
/cc @kragniz
cc @nixgadget @gordcorp

Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 8, 2019
@jetstack-bot jetstack-bot added this to the v0.6 milestone Feb 8, 2019
@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2019
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz munnerz added this to Needs review in v0.6 Feb 8, 2019
Copy link
Contributor

@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

v0.6 automation moved this from Needs review to Reviewer approved Feb 11, 2019
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit b6210be into cert-manager:master Feb 11, 2019
v0.6 automation moved this from Reviewer approved to Done Feb 11, 2019
@deiwin
Copy link

deiwin commented Feb 11, 2019

Is there an ETA for a release that would include this patch?

@munnerz munnerz deleted the bump-k8s-110 branch February 11, 2019 20:21
jetstack-bot added a commit that referenced this pull request Feb 11, 2019
@viswadeep
Copy link

how would I get these changes? I am having the same problem as well.

@w32-blaster
Copy link

w32-blaster commented Feb 12, 2019

Same by me. I just got blocked by this issue, so a patch release would help us.

!EDIT:
You can use the image tag :canary to get the latest code merged into master, until we get a new release

@whereisaaron
Copy link
Contributor

The aggregation layer isn't working in EKS only due to this dependency, so a release if only with this patch would be helpful.

@viswadeep
Copy link

I had the same issue for Cassandra API server on EKS,
I see the authentication layer code looking for a certificate from data (map) in extension-apiserver-authentication config map. Looking at the https://github.com/jetstack/navigator/blob/master/vendor/k8s.io/apiserver/pkg/server/options/authentication.go, if possible get the certificate from a service account and place it! (simple workaround).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
No open projects
v0.6
  
Done
Development

Successfully merging this pull request may close these issues.

Getting "cluster doesn't provide client-ca-file"
7 participants