Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Go 1.12 #1429

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Bump to Go 1.12 #1429

merged 1 commit into from
Apr 12, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Mar 1, 2019

What this PR does / why we need it:

Bump to use Go 1.12

Release note:

Bump to use Go 1.12

/area deploy

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Mar 1, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2019
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2019
@munnerz munnerz added this to the v0.8 milestone Mar 7, 2019
@munnerz munnerz added this to In progress in v0.8 Apr 10, 2019
@munnerz
Bump to Go 1.12
2425df3 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2019
@munnerz munnerz added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2019
@jetstack-bot jetstack-bot merged commit 3ca100f into cert-manager:master Apr 12, 2019
v0.8 automation moved this from In progress to Done Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielMorsing DanielMorsing Awaiting requested review from DanielMorsing

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
v0.8
  
Done
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@munnerz @jetstack-bot