-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'solvers' configuration to ACME Issuer #1450
Add 'solvers' configuration to ACME Issuer #1450
Conversation
116a108
to
e488ba8
Compare
1e711b5
to
a74b005
Compare
12833ec
to
10789d6
Compare
11fd07e
to
c508425
Compare
// List of DNSNames that can be used to further refine the domains that | ||
// this solver applies to. | ||
// +optional | ||
DNSNames []string `json:"dnsNames,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @Evesy this field currently only supports exact matches, FYI
IngressClass *string `json:"ingressClass,omitempty"` | ||
|
||
// +optional | ||
IngressName string `json:"ingressName,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @kragniz should these two fields be Class
and Name
to avoid the stutter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to Name and Class 😄
d11aae2
to
70f0d8c
Compare
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
7fdf1f4
to
3682b18
Compare
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
5a93273
to
55c6e6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question and a couple of suggestions, happy to merge
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
b5c8968
to
7945a6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kragniz, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This is a very WIP first pass at moving the ACME certificate config over to the Issuer resource in a backwards compatible manner.
We'll remove support for the old syntax at {some point} (either pre-1.0, or for 1.0).
Mostly pushing this up to see if the e2e tests (which have not changed) will pass 😄
A (very verbose) example of an Issuer using a mixture of new and old configuration, and also including an example of how the 'webhook' code in #1443 can be adapted for HTTP01:
Which issue this PR fixes: fixes #1342
Special notes for your reviewer:
Release note:
/cc @DanielMorsing