[Azure DNS] Fixes trimming of zone inferred via zone discovery

[logicfox]

Signed-off-by: Aditya Sundaramurthy aditya.sundaramurthy@gmail.com

What this PR does / why we need it: Fixes #1459 . Uses inferred zone name from the Azure DNS API over the configured hostedZoneName param in the ClusterIssuer

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1459

Special notes for your reviewer: Overrides hostedZoneName config param.

Release note:

Removes need for `hostedZoneName` to be specified. Uses discovered DNS zone name instead.

[jetstack-bot]

Hi @logicfox. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[logicfox]

/assign @DanielMorsing

[DanielMorsing]

Not sure I understand what this is trying to fix. Could you explain a bit?

[logicfox]

Fixes #1459 . When using Azure DNS, the TXT record used for the DNS01 challenge is set incorrectly when the ClusterIssuer CRD is not configured with the hostedZoneName parameter. The domain name is repeated twice in the TXT record, i.e. instead of _acme-challenge.mycompany.com, the record is created for _acme-challenge.mycompany.com.mycompany.com when the hostedZoneName parameter is not set in the ClusterIssuer CRD.

The issue can be traced to the existing code which trims the domain from the fqdn based on the zoneName field in the DNSProvider struct in the trimFqdn function. This field is not set if the hostedZoneName param is not set.

To mitigate this error, the domain name used in the trimFqdn function should be the zone name discovered through the getHostedZoneName function.

[munnerz]

Thanks for the PR 😄

I think this needs modifying to still allow overriding the parameter using hostedZoneName, else it becomes a backwards incompatible change.

We may remove the hostedZoneName field in the future, but we needn't do it as part of this PR given we can check to see if it is set, and otherwise fall back to the detected zone 😄

[munnerz]

/ok-to-test

[logicfox]

Makes sense. I'll fix that to default to the hostedZoneName if provided.

[tommy-dk]

@logicfox: Nice work! Seems to fix the bug I reported. 👍

[munnerz]

/lgtm
/approve
/milestone v0.7

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicfox, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [munnerz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment