Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): updated quickstart docs #1468

Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix(docs): updated quickstart docs #1468

merged 1 commit into from
Mar 13, 2019

Conversation

BradErz
Copy link
Contributor

@BradErz BradErz commented Mar 11, 2019 •
edited

Updated the quickstart documentation to use the new jetstack helm repo.

What this PR does / why we need it:
To fix the documentation so people don't end up pulling out their hair wondering why the stable/cert-manager chart is only pulling version 0.6.2 of the code but the CRD's are from version 0.7.0.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

fixing the quickstart documentation to use the new helm chart repo charts.jetstack.io

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/documentation Categorizes issue or PR as related to documentation. labels Mar 11, 2019
@jetstack-bot
Copy link
Contributor

Hi @BradErz. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2019
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 11, 2019
@munnerz
Copy link
Member

munnerz commented Mar 12, 2019

🙈 this was an oversight!!

@BradErz
fix(docs): updated quickstart docs
dfe5aaf 
Updated the quickstart documentation to use the new jetstack helm repo.

Signed-off-by: Bradley Wilson-Hunt <bwilsonhunt@gmail.com>
@BradErz
Copy link
Contributor Author

BradErz commented Mar 12, 2019

this was an oversight!!

grateful for the hard work on 0.7.0 btw!

its easy to miss, i just caught it cause i happened to be installing a new test cluster last night just after you made the release.

@munnerz
Copy link
Member

munnerz commented Mar 13, 2019

Thanks Bradley! 😄 (long-time-no-see!)

/lgtm
/approve
/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2019
@munnerz munnerz added this to the v0.7 milestone Mar 13, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BradErz, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@jetstack-bot jetstack-bot merged commit b5a38b9 into cert-manager:master Mar 13, 2019
@BradErz BradErz deleted the patch-1 branch March 13, 2019 12:04
@munnerz munnerz mentioned this pull request Mar 13, 2019
Merged
jetstack-bot added a commit that referenced this pull request Mar 13, 2019
@jetstack-bot
Merge pull request #1472 from munnerz/automated-cherry-pick-of-#1468-…
0256fee 
…release-0.7

Automated cherry pick of #1468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz munnerz left review comments

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BradErz @jetstack-bot @munnerz