Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make email address an optional field in ACME issuers #1483

Merged
merged 1 commit into from
May 7, 2019

Conversation

DanielMorsing
Copy link
Contributor

What this PR does / why we need it:
Email addresses aren't required by the acme standard. Bring the configuration into line with the spec

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
fixes #1428

Special notes for your reviewer:

Release note:

Make ACME email addresses optional

@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 18, 2019
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2019
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2019
@jetstack-bot jetstack-bot removed approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 1, 2019
@munnerz
Copy link
Member

munnerz commented May 2, 2019

/retest

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2019
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2019
@munnerz
Copy link
Member

munnerz commented May 7, 2019

/test all

1 similar comment
@munnerz
Copy link
Member

munnerz commented May 7, 2019

/test all

@munnerz
Copy link
Member

munnerz commented May 7, 2019

/retest

@munnerz
Copy link
Member

munnerz commented May 7, 2019

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DanielMorsing, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2019
@jetstack-bot
Copy link
Contributor

@DanielMorsing: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cert-manager-e2e-v1-13 71c87c9 link /test e2e v1.13

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@munnerz
Copy link
Member

munnerz commented May 7, 2019

/override pull-cert-manager-e2e-v1-13

@jetstack-bot
Copy link
Contributor

@munnerz: Overrode contexts on behalf of munnerz: pull-cert-manager-e2e-v1-13

In response to this:

/override pull-cert-manager-e2e-v1-13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot merged commit 15265dd into cert-manager:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make spec.acme.email optional
3 participants