Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to go modules #1523

Merged
merged 8 commits into from
Apr 14, 2019
Merged

Switch to go modules #1523

merged 8 commits into from
Apr 14, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Apr 3, 2019 •
edited

What this PR does / why we need it:

This switches to use go modules instead of dep for dependency management.

This speeds up calls to {verify,update}-deps.sh to about 2 minutes instead of 12 馃槃

Release note:

Switch to go modules for dependency management

@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Apr 3, 2019
@munnerz munnerz changed the title WIP: Switch to gomod WIP: Switch to go modules Apr 3, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 3, 2019
@munnerz munnerz force-pushed the gomod branch 3 times, most recently from de959b3 to 8a2bd13 Compare April 4, 2019 13:26
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Apr 4, 2019
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Apr 4, 2019
@munnerz munnerz mentioned this pull request Apr 10, 2019
Closed
@munnerz munnerz force-pushed the gomod branch 5 times, most recently from c19dc86 to 7bc47f6 Compare April 14, 2019 14:39
@jetstack-bot jetstack-bot added the area/testing Issues relating to testing label Apr 14, 2019
@munnerz munnerz mentioned this pull request Apr 14, 2019
Closed
@munnerz
Update dependency management tools for go modules
f835a5a 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update buildozer dependency
6900752 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Run go mod init
ce1898e 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Run ./hack/update-vendor.sh
e72dbef 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Bump Kubernetes dependencies to master with go mod support
113b382 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Run ./hack/update-vendor.sh
fab0954 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update reference to deprecated method
b3ec6a6 
Signed-off-by: James Munnelly <james@munnelly.eu>
@munnerz
Update reference docs
b86b232 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 14, 2019
@munnerz
Copy link
Member Author

munnerz commented Apr 14, 2019

/retest

@munnerz munnerz removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2019
@munnerz munnerz changed the title WIP: Switch to go modules Switch to go modules Apr 14, 2019
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2019
@munnerz munnerz added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2019
@jetstack-bot jetstack-bot merged commit 3a747cd into cert-manager:master Apr 14, 2019
@jetstack-bot jetstack-bot mentioned this pull request Apr 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielMorsing DanielMorsing Awaiting requested review from DanielMorsing

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@munnerz @jetstack-bot