Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Present and CleanUp run in serial #155

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Ensure Present and CleanUp run in serial #155

merged 1 commit into from
Oct 26, 2017

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Oct 26, 2017

What this PR does / why we need it:

Fixes a race in the ACME HTTP solver when using multiple domains.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Closes #153

Special notes for your reviewer:

Release note:

Fix race condition in ACME HTTP01 solver when validating multiple domains

@munnerz munnerz added this to the v0.1 milestone Oct 26, 2017
@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 26, 2017
@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2017
@munnerz munnerz added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2017
@munnerz
Copy link
Member Author

munnerz commented Oct 26, 2017

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2017
@jetstack-bot
Copy link
Contributor

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@jetstack-bot jetstack-bot merged commit 001e40e into cert-manager:master Oct 26, 2017
This was referenced Oct 26, 2017
Merged
Closed
jetstack-bot added a commit that referenced this pull request Oct 26, 2017
@jetstack-bot
Merge pull request #157 from munnerz/automated-cherry-pick-of-#155-up…
20a7e88 
…stream-release-0.1

Automatic merge from submit-queue.

Automated cherry pick of #155

Cherry pick of #155 on release-0.1.

#155: Ensure Present and CleanUp run in serial
@munnerz munnerz mentioned this pull request Oct 26, 2017
Closed
@jetstack-bot
Copy link
Contributor

Commit found in the "release-0.1" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@munnerz munnerz deleted the fix-race branch January 29, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simonswine simonswine

@dippynark dippynark

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.

fatal error: concurrent map writes
4 participants
@munnerz @jetstack-bot @simonswine @dippynark