Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ACME HTTP01 reachability test passes 5 times before issuing certificate #156

Merged
merged 1 commit into from
Oct 26, 2017

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Oct 26, 2017

What this PR does / why we need it:

See #154 for details. Sometimes HTTP routes have not propagated yet when using a controller such as GCLB. This forces us to wait for 5 consecutive passes of the HTTP01 self-check before proceeding.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Closes #154

Special notes for your reviewer:

  • This adds an extra 10s delay onto any HTTP01 validation
  • The '5 tries' number is hardcoded into the HTTP01 solver

Release note:

Ensure 5 consecutive HTTP01 self-checks pass before issuing ACME certificate

@munnerz munnerz added this to the v0.1 milestone Oct 26, 2017
@munnerz munnerz self-assigned this Oct 26, 2017
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2017
@munnerz munnerz changed the title Ensure ACME HTTP01 reachability test passes 5 times before issuing ce… Ensure ACME HTTP01 reachability test passes 5 times before issuing certificate Oct 26, 2017
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@munnerz munnerz added the area/acme Indicates a PR directly modifies the ACME Issuer code label Oct 26, 2017
@munnerz munnerz added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Oct 26, 2017
@jetstack-bot
Copy link
Contributor

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@jetstack-bot jetstack-bot merged commit d5a5c63 into cert-manager:master Oct 26, 2017
jetstack-bot added a commit that referenced this pull request Oct 26, 2017
…stream-release-0.1

Automatic merge from submit-queue.

Automated cherry pick of #156

Cherry pick of #156 on release-0.1.

#156: Ensure ACME HTTP01 reachability test passes 5 times before
@jetstack-bot
Copy link
Contributor

Commit found in the "release-0.1" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@munnerz munnerz deleted the require-5-http-passes branch January 29, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCLB routes have not propagated when self-check passes
2 participants