Add DNS01 provider conformance test suite #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
release-note
jetstack-bot
added
the
approved
munnerz
force-pushed
the
dns01-test-suite
branch
from
ed2f668
to
d1c0dc0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kragniz, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
munnerz
force-pushed
the
dns01-test-suite
branch
from
d1c0dc0
to
9b70053
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Requires #1561
Part of #1443
Add a DNS01 provider testing suite. This can be used to validate each provider performs according to cert-manager's requirements.
It requires credentials to be made available via the
testdata/directory in order for the tests to run properly.I've adapted the cloudflare and rfc2136 providers to pass the basic suite.
We can then require that all new DNS implementations pass this suite before they can be used.
Which issue this PR fixes: fixes #774
Special notes for your reviewer:
This is still obviously WIP and experimental, but I want to get it in so we can publish the webhook example repo 馃槃
Release note:
/area acme/dns01