Add webhook dns provider implementation #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
release-note
jetstack-bot
added
dco-signoff: yes
munnerz
force-pushed
the
webhook-dns-provider
branch
from
acbccdf
to
ddd2336
Compare
Signed-off-by: James Munnelly <james@munnelly.eu>
munnerz
force-pushed
the
webhook-dns-provider
branch
from
ddd2336
to
d4d21b7
Compare
Signed-off-by: James Munnelly <james@munnelly.eu>
munnerz
force-pushed
the
webhook-dns-provider
branch
from
d4d21b7
to
af9bce7
Compare
munnerz
changed the title
jetstack-bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kragniz, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e v1.13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the actual webhook DNS provider to the codebase.
This PR only adds the new one, I am going to follow up with a PR that refactors the cloudflare and rfc2136 provider to use this new format too.
I'd also like to set up an e2e test that verifies that a Challenge moves into the 'Presented' state when this is used with a dummy DNS01 provider that always returns OK.
Release note:
/cc @kragniz