Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added static label for solver identification. Solves #1529 #1575

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Added static label for solver identification. Solves #1529 #1575

merged 2 commits into from
Apr 26, 2019

Conversation

christianhuening
Copy link
Contributor

@christianhuening christianhuening commented Apr 24, 2019 •
edited

Signed-off-by: Christian Hüning christian.huening@figo.io

What this PR does / why we need it:
Adds labels to the solver pod in order to allow for customer service manifests to pick it up

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fixes #1529
Special notes for your reviewer:

Release note:

- add static label for solver identification to allow usage of custom service

added static label for solver identification. Solves cert-manager#1529
1e73962 
Signed-off-by: Christian Hüning <christian.huening@figo.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 24, 2019
@jetstack-bot jetstack-bot added the area/acme Indicates a PR directly modifies the ACME Issuer code label Apr 24, 2019
@jetstack-bot
Copy link
Contributor

Hi @christianhuening. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2019
@munnerz
Copy link
Member

munnerz commented Apr 25, 2019

Thanks for this PR 😄 I've added one comment, notably I think we can make the label values simpler (a simple 'true'/'false')

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2019
Rename label as requested
149f830 
Signed-off-by: Christian Hüning <christian.huening@figo.io>
@christianhuening
Copy link
Contributor Author

/retest

@christianhuening
Copy link
Contributor Author

@munnerz So this should do the trick

@munnerz
Copy link
Member

munnerz commented Apr 26, 2019

Would you mind editing your initial pr comment to include a release note, then the bot should automatically merge your PR 😄 thanks!

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianhuening, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 26, 2019
@jetstack-bot jetstack-bot merged commit bf50c5d into cert-manager:master Apr 26, 2019
leesiongchan added a commit to leesiongchan/ambassador that referenced this pull request Jul 16, 2019
@leesiongchan
Update cert-manager documentation
2e9daa1 
Issue (cert-manager/cert-manager#1529) and PR (cert-manager/cert-manager#1575) have provided a static label, we can use that instead of manually checking for  `acme-http-domain` and `acme-http-token`
@leesiongchan leesiongchan mentioned this pull request Jul 16, 2019
Closed
@leesiongchan leesiongchan mentioned this pull request Aug 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz munnerz left review comments

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label to match the http challenge pod
3 participants
@christianhuening @jetstack-bot @munnerz