Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle expired challenge responses in acmechallenges controller #1603

Merged
merged 1 commit into from
May 1, 2019
Merged

Handle expired challenge responses in acmechallenges controller #1603

merged 1 commit into from
May 1, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Apr 30, 2019 •
edited

What this PR does / why we need it:

Updates the acmechallenges controller to handle 'challenge expired' responses from the acme server.

This will in turn trigger a retry of the order eventually.

Which issue this PR fixes: fixes #1232, fixes #1589

Release note:

Automatically retry expired Challenge resources

@munnerz
Handle expired challenge responses in acmechallenges controller
bbf4012 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Apr 30, 2019
@jetstack-bot jetstack-bot added area/acme Indicates a PR directly modifies the ACME Issuer code approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2019
@munnerz
Copy link
Member Author

munnerz commented Apr 30, 2019

/retest

kragniz
kragniz approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 4f6d771 into cert-manager:master May 1, 2019
@eugenestarchenko eugenestarchenko mentioned this pull request May 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kragniz kragniz kragniz approved these changes

Assignees

@kragniz kragniz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gracefully handle 'expired' authorization state Add standard ACME err handler for use in Challenges & Orders
3 participants
@munnerz @jetstack-bot @kragniz