Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange docs after new solver changes and remove old content #1623

Merged
merged 2 commits into from
May 2, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented May 2, 2019

What this PR does / why we need it:

Makes a start at re-organising the documentation now that we've removed ACME configuration from Certificate resources.

This makes our docs generally read a lot better, as we can tell users to configure their ACME issuer on the setup issuer section, and then all issuers can share a single 'issuing certificates' guide.

We'll need to make a note/link/call out to a 'debugging ACME orders' guide still at some point - I currently do this in the setting up ACME issuers guide, but will add a note to the issuing certificates doc too.

Which issue this PR fixes: fixes #1612, #1610, #1609

Release note:

Update documentation for new 'solvers' field

Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels May 2, 2019
@jetstack-bot jetstack-bot added kind/documentation Categorizes issue or PR as related to documentation. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2019
Copy link
Contributor

@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kragniz, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit d9cf033 into cert-manager:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite/remove "ACME specific tasks" part of documentation
3 participants